feat(trainer): add trainer support #3653
Open
+1,288
−763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrancescoBorzi
approved these changes
Dec 29, 2025
previously, this column only showed a few characters and was not readable
Helias
reviewed
Jan 8, 2026
| export class SelectTrainerComponent extends SelectComponent<Trainer> { | ||
| protected override readonly entityTable = TRAINER_TABLE; | ||
| protected override readonly entityIdField = TRAINER_ID; | ||
| readonly customStartingId = 1000000; |
Helias
reviewed
Jan 8, 2026
| } | ||
| }, | ||
| "resolutions": { | ||
| "ora": "5.4.1" |
Member
There was a problem hiding this comment.
why? are you sure that it should not be under overrides?
Helias
reviewed
Jan 8, 2026
|
|
||
| export class Trainer extends TableRow { | ||
| Id: number = 0; | ||
| Type: number = 2; |
Member
There was a problem hiding this comment.
what is 2? do we have a real type for this Type field? let's use a const enum?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires:
fix(Core/Creature): port TC handling of Trainers azerothcore-wotlk#23040
Closes npc_trainer align AC #3644
This is missing tests, and the PR is incompatible with the below (the other needs to be updated if either is merged)