Conversation
Yehonal
requested changes
Jun 26, 2025
…LI, and admin notices
- Added a reusable flash message system for admin notices. - Registered the flash message display with the admin_notices hook. - Improved the wp_login hook to work reliably with $_POST data. - Added a dedicated hook for GraphQL login (graphql_login_after_authenticate) to support account creation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR introduces a static method
AcoreUtils::handle_acore_error()that provides unified error handling for both GraphQL and standard WordPress requests.Purpose
The goal is to centralize error handling logic across the plugin and ensure consistent behavior depending on the request context:
GRAPHQL_HTTP_REQUESTis defined and set totrue, aUserErrorexception is thrown, which is properly handled by the GraphQL layer.Benefits
Technical Notes
GRAPHQL_HTTP_REQUESTconstant is defined by WPGraphQL to indicate incoming GraphQL HTTP requests.wp_redirect()is followed byexitto stop further execution after redirecting.esc_html()is used to ensure safe output in the admin notice.Potential Improvements