feat: update Docker environment variables for database configuration#158
Merged
Yehonal merged 7 commits intoazerothcore:masterfrom Jul 12, 2025
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Refactors the Docker Compose setup to pull database connection values from environment variables with sensible defaults.
- Switches fixed MySQL credentials to use
${VAR:-default}fallbacks - Updates the WordPress service to reference the same DB vars
- Adds commented example entries for the new DB variables in
.env.docker
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docker-compose.yml | Replaced static MySQL/WordPress credentials with environment fallbacks |
| .env.docker | Added commented examples for new DOCKER_WORDPRESS_DB_* variables |
Comments suppressed due to low confidence (1)
.env.docker:20
- [nitpick] Add a short note or update the project README to explain these new database environment variables and how to override them for different environments.
# DOCKER_WORDPRESS_DB_ROOT_PASSWORD=flkdsjalfh
…uration for nginx
…or acore-cms-maintenance service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor database configuration in the Docker setup to utilize environment variables for better flexibility and security.