Addition "gift" into Smartstone Implementation #170
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Member
|
Thanks for PR! I'm glad you are getting familiar with the code :) But I was wondering: why being logged in is a requirement? |
Contributor
Author
|
The shop requires account login to be added to the cart |
Member
|
Ok thanks, I thought the in game account |
Contributor
Author
|
CC @Helias |
Helias
approved these changes
Oct 2, 2025
Contributor
Author
|
do not merge, currentlytesting |
Contributor
Author
|
I can't get this to work and im unsure if it's just the submodule not updating correctly for the other cms because i cant test it locally |
Contributor
Author
|
I need to revisit this with another view as i'm unsure why it doesn't work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements: That you're logged in, that you select a character to send from and a character to send to.
The title and body should start with $Character has sent you $item.
Missing, as mentioned by randalf
