Skip to content

fix(Scripts/TempestKeep): Add Teleport Position to Astromancer Solarian and Threat Reset#24622

Merged
Gultask merged 3 commits intoazerothcore:masterfrom
Gultask:6958
Feb 6, 2026
Merged

fix(Scripts/TempestKeep): Add Teleport Position to Astromancer Solarian and Threat Reset#24622
Gultask merged 3 commits intoazerothcore:masterfrom
Gultask:6958

Conversation

@Gultask
Copy link
Contributor

@Gultask Gultask commented Feb 5, 2026

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

AI-assisted Pull Requests

Important

While the use of AI tools when preparing pull requests is not prohibited, contributors must clearly disclose when such tools have been used and specify the model involved.

Contributors are also expected to fully understand the changes they are submitting and must be able to explain and justify those changes when requested by maintainers.

  • AI tools (e.g. ChatGPT, Claude, or similar) were used entirely or partially in preparing this pull request. Please specify which tools were used, if any.

Issues Addressed:

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Build 50791

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

Copilot AI review requested due to automatic review settings February 5, 2026 00:10
@github-actions github-actions bot added DB related to the SQL database Script Refers to C++ Scripts for the Core file-cpp Used to trigger the matrix build labels Feb 5, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the Astromancer Solarian encounter in The Eye (Tempest Keep) by implementing a teleport to the boss's start position during the spotlight phase and adding a threat reset after the teleport sequence completes. The fix addresses issue #6958 from chromiecraft and is based on sniff data from build 50791.

Changes:

  • Implements boss teleport to start position during spotlight phase using spell 33244
  • Adds threat reset when boss returns to combat after spotlight phase
  • Adds database entry for teleport spell target position

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/server/scripts/Outland/TempestKeep/Eye/boss_astromancer.cpp Adds "Serverside" comment to spell, implements teleport cast at phase start, and adds threat clear before returning to aggressive state
data/sql/updates/pending_db_world/rev_1770249033416011200.sql Defines spell target position for teleport spell (Map 550, coordinates matching START_POSITION constants)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Gultask and others added 2 commits February 4, 2026 21:29
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Gultask Gultask merged commit 8249ca5 into azerothcore:master Feb 6, 2026
17 checks passed
@Gultask Gultask deleted the 6958 branch February 6, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DB related to the SQL database file-cpp Used to trigger the matrix build Ready to be Reviewed Script Refers to C++ Scripts for the Core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TK] Solarian split event wrong sequence

2 participants