fix: rename id1 to id for AzerothCore compatibility#77
Merged
Nyeriah merged 1 commit intoazerothcore:masterfrom Mar 23, 2026
Merged
fix: rename id1 to id for AzerothCore compatibility#77Nyeriah merged 1 commit intoazerothcore:masterfrom
Nyeriah merged 1 commit intoazerothcore:masterfrom
Conversation
AzerothCore PR #25197 normalizes the creature table by moving id2/id3 into a separate creature_multispawn table and renaming id1 back to id. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
14 tasks
Nyeriah
added a commit
that referenced
this pull request
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cr_data->id1tocr_data->idin two places to match AzerothCore's upcoming database normalization (PR refactor(Core/DB): normalize creature table by extracting multi-ID spawns azerothcore-wotlk#25197)id2/id3into a separatecreature_multispawntable and renamesid1back toidChanges
src/mod_guildhouse.cppline 81:cr_data->id1→cr_data->idsrc/mod_guildhouse.cppline 281:cr_data->id1→cr_data->id🤖 Generated with Claude Code