Skip to content

fix(DB): rename structure.sql to fix duplicate filename CI error#199

Closed
Nyeriah wants to merge 1 commit intomasterfrom
fix-duplicate-structure-sql
Closed

fix(DB): rename structure.sql to fix duplicate filename CI error#199
Nyeriah wants to merge 1 commit intomasterfrom
fix-duplicate-structure-sql

Conversation

@Nyeriah
Copy link
Copy Markdown
Member

@Nyeriah Nyeriah commented Apr 3, 2026

Summary

  • Renames data/sql/db-world/structure.sql to data/sql/db-world/mod_ptrtemplate_structure.sql
  • The AzerothCore DB updater requires all SQL filenames to be unique across the entire project (core + all modules)
  • The generic name structure.sql causes a duplicate filename collision during the nopch-module-build CI job on azerothcore-wotlk, which has been failing since at least March 29th

CI Error

Duplicate filename ".../modules/mod-ptr-template/data/sql/db-world/structure.sql" occurred.
Because updates are ordered by their filenames, every name needs to be unique!
Could not update the World database, see log for details.

Test plan

  • Verify nopch-module-build CI passes on azerothcore-wotlk after this merge
  • Verify module installs cleanly with the renamed SQL file

🤖 Generated with Claude Code

The AzerothCore DB updater requires all SQL filenames to be unique
across the entire project. The generic name "structure.sql" conflicts
with other modules, breaking the nopch-module-build CI on the main repo.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
heyitsbench added a commit that referenced this pull request Apr 3, 2026
Avoid collisions with other DB query files across the upstream core and other modules.

Supersedes #199.
@heyitsbench heyitsbench closed this Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants