Skip to content

Adds support for deleting multiple spells in the aura nerf system. #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adds support for deleting multiple spells in the aura nerf system. #57

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5d9661
Adds support for deleting multiple spells in the aura nerf system.
EricksOliveira Jan 2, 2025
553784b
Add Spell Exclusion Logic to OnAuraApply with Optimized Direct Check …
EricksOliveira Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/mod_zone_difficulty_scripts.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,12 @@ class mod_zone_difficulty_unitscript : public UnitScript
public:
mod_zone_difficulty_unitscript() : UnitScript("mod_zone_difficulty_unitscript") { }

bool IsExcludedSpell(uint32 spellId)
{
static const std::unordered_set<uint32> excludedSpells = { 31852, 31851, 31850 };
return excludedSpells.find(spellId) != excludedSpells.end();
}

void OnAuraApply(Unit* target, Aura* aura) override
{
if (!sZoneDifficulty->IsEnabled)
Expand All @@ -38,7 +44,7 @@ class mod_zone_difficulty_unitscript : public UnitScript
uint32 mapId = target->GetMapId();
bool nerfInDuel = sZoneDifficulty->ShouldNerfInDuels(target);

//Check if the map of the target is subject of a nerf at all OR if the target is subject of a nerf in a duel
// Check if the map of the target is subject to a nerf at all OR if the target is subject to a nerf in a duel
if (sZoneDifficulty->ShouldNerfMap(mapId) || nerfInDuel)
{
if (SpellInfo const* spellInfo = aura->GetSpellInfo())
Expand All @@ -47,6 +53,10 @@ class mod_zone_difficulty_unitscript : public UnitScript
if (spellInfo->HasAttribute(SPELL_ATTR0_NO_IMMUNITIES))
return;

// Use the function to skip excluded spells
if (IsExcludedSpell(spellInfo->Id))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just checkk for the spell ids here instead of adding another iteration please

return;

if (spellInfo->HasAura(SPELL_AURA_SCHOOL_ABSORB))
{
std::list<AuraEffect*> AuraEffectList = target->GetAuraEffectsByType(SPELL_AURA_SCHOOL_ABSORB);
Expand Down Expand Up @@ -81,7 +91,7 @@ class mod_zone_difficulty_unitscript : public UnitScript
absorb = eff->GetAmount() * sZoneDifficulty->NerfInfo[DUEL_INDEX][0].AbsorbNerfPct;
}

//This check must be last and override duel and map adjustments
// This check must be last and override duel and map adjustments
if (sZoneDifficulty->SpellNerfOverrides.find(spellInfo->Id) != sZoneDifficulty->SpellNerfOverrides.end())
{
if (sZoneDifficulty->SpellNerfOverrides[spellInfo->Id].find(mapId) != sZoneDifficulty->SpellNerfOverrides[spellInfo->Id].end())
Expand Down