Skip to content

New: ItemSet.dbc and updated Item_set_names sand Item_template to match new changes#1018

Merged
Kitzunu merged 10 commits intoazerothcore:masterfrom
TheSCREWEDSoftware:ItemSet.dbc
Mar 2, 2025
Merged

New: ItemSet.dbc and updated Item_set_names sand Item_template to match new changes#1018
Kitzunu merged 10 commits intoazerothcore:masterfrom
TheSCREWEDSoftware:ItemSet.dbc

Conversation

@TheSCREWEDSoftware
Copy link
Copy Markdown
Contributor

Description

  • Created ItemSet.dbc (itemset_dbc.md)
  • Updated item_set_names (item_set_names.md)
  • Updated item_template (item_template.md)

Related Issue

Not aware

@pangolp new changes to EN files

Copy link
Copy Markdown
Member

@Kitzunu Kitzunu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

| Field | Type | Attributes | Key | Null | Default | Extra | Comment |
| --------------------------------------- | ------- | ---------- | --- | ---- | ------- | ----- | ------- |
| [ID](#id) | INT | SIGNED | PRI | NO | 0 | | |
| [Name_Lang_enUS](#name_lang_enus) | VARCHAR | SIGNED | | YES | NULL | | |
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI these links won't work. in a relative link to a header you cannot use special characters.

so a link to this header would be #namelangenus

## Name_Lang_enUS

(#name_lang_enus) -> Dont work
(#namelangenus) -> Work

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BUT to be clear. underscores in file names do work

@TheSCREWEDSoftware
Copy link
Copy Markdown
Contributor Author

Corrected

@TheSCREWEDSoftware
Copy link
Copy Markdown
Contributor Author

Ready to be reviewed.


The required skill rank the player needs to have to use this Item Set.

### DBC File Content
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this. DBC is copyrighted by Blizzard. And we do not need to share the contents of it anyways as you can simply open a dbc editor.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


<details>

<summary>Click to view</summary>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see the use for details

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While sure item_set_names is a small page, using <details> more often would save in a lot of page scroll.

From this

image

to

image

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see why it could be nice. But I think it should be accessible at face value in a wiki

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When im back at pc I will remove it and make a push then

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment on lines +545 to +547
<details>

<summary>Click to view</summary>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are still using details...

| 26 | Ranged right (Wands, Guns) (see also Ranged = 15) |
| 27 | Quiver |
| 28 | Relic (class = armor, not weapon even if in weapon slot) |
| 28 | Relic (class = armor, not weapon even if in weapon slot)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| 28 | Relic (class = armor, not weapon even if in weapon slot)
| 28 | Relic (class = armor, not weapon even if in weapon slot) |

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@Kitzunu
Copy link
Copy Markdown
Member

Kitzunu commented Feb 23, 2025

after that last change I will merge

@Kitzunu
Copy link
Copy Markdown
Member

Kitzunu commented Mar 1, 2025

You need to update item_template.md #1018 (comment)

@Kitzunu Kitzunu merged commit f8df9be into azerothcore:master Mar 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants