Add helm chart linting and snapshot testing #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CI error: Unable to reach |
Alex-Welsh
commented
Jul 2, 2025
Co-authored-by: Scott Davidson <[email protected]>
sd109
reviewed
Jul 3, 2025
Contributor
|
Previous CI run passed before trivial update to CONTRIBUTING.md so cancelling latest run and merging anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to fiddle with the template validation a bit, dependency build was required for reloader and additional schemas were required for cert-manager. They worked locally, but I have no idea how they will work in CI.
Implementation based on azimuth-cloud/cluster-api-janitor-openstack#192