Skip to content
This repository was archived by the owner on Mar 31, 2023. It is now read-only.

wrapper for webpack#15

Open
vugluskr86 wants to merge 4 commits intoazuqua:masterfrom
vugluskr86:master
Open

wrapper for webpack#15
vugluskr86 wants to merge 4 commits intoazuqua:masterfrom
vugluskr86:master

Conversation

@vugluskr86
Copy link

No description provided.

@aembke
Copy link
Contributor

aembke commented May 17, 2016

Just realized this repo wasn't hooked up to travis so I'm going to close and re-open this to trigger a rebuild.

@aembke aembke closed this May 17, 2016
@aembke aembke reopened this May 17, 2016
@vugluskr86
Copy link
Author

vugluskr86 commented May 17, 2016

Travis build failed.

Running "jshint:files" (jshint) task
   clients/browser/tokensockjs.js
     53 |            'use strict';
                     ^ Unnecessary directive "use strict".

I remove 'use strict'; and repeat the commit?

@aembke
Copy link
Contributor

aembke commented May 17, 2016

Sure, I tried it last night and it seems the webpack wrapper has some undefined references (module, exports, require) that aren't available in an environment without webpack. Since we have several use cases that do not use webpack we'll need a way to write this such that it works with or without webpack. I'll take a look at it this weekend and write some test cases, but feel free to make any changes in the meantime.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants