Batch: Add Support for Options Bags and Certificates to Dataplane SDK (Azure#44722)

* Remove all handwritten Options Bag methods

* Delete more handwritten options classes

* Delete the rest of the generated models

* Delete the rest of the generated files

* Update tsp location hash

* Regenerate SDK from new TypeSpec

* Add back handwritten fromException method

* Fix errors in generated sample and test files

* Regenerate to fix formatting

* Add createTasks method to both clients

* Fix errors in unit tests

* Fix getNodeFileProperties method in both clients

* Fix getTaskFileProperties method in both clients

* Add AzureNamedKeyCredential to client builder

* Add cspell overrides for generated sample files

* Add cspell suppressions

* Update TypeSpec commit hash

* Delete unnecessary generated samples and tests

* Regenerate SDK from latest TypeSpec

* Remove cspell exceptions

* Update Javadocs

* Fix Readme

* Add changelog

* Fix changelog version

Author: skapur12

sdk/batch/azure-compute-batch/CHANGELOG.md

@@ -1,14 +1,18 @@
 # Release History
 
-## 1.0.0-beta.4 (Unreleased)
+## 1.0.0-beta.4 (2025-03-24)
 
 ### Features Added
 
+- Re-added support for certificates:
+  - Added `createCertificate(BatchCertificate certificate)`, `listCertificates()`, `cancelCertificateDeletion(String thumbprintAlgorithm, String thumbprint)`, `deleteCertificate(String thumbprintAlgorithm, String thumbprint)`, and `getCertificate(String thumbprintAlgorithm, String thumbprint)` methods to `BatchClient` and `BatchAsyncClient`.
+
 ### Breaking Changes
 
-### Bugs Fixed
+- Renamed `GetApplicationOptions` to `GetBatchApplicationOptions` (the name of the class of optional parameters for the `getApplication(String applicationId)` method).
 
-### Other Changes
+- For several methods in `BatchClient` and `BatchAsyncClient` with an optional parameter group, the `requestConditions` parameter was moved out of the optional parameter group and is now a separate parameter.
+  - Affected methods: `deletePool`, `poolExists`, `getPool`, `updatePool`, `enablePoolAutoScale`, `resizePool`, `stopPoolResize`, `removeNodes`, `deleteJob`, `getJob`, `updateJob`, `replaceJob`, `disableJob`, `enableJob`, `terminateJob`, `jobScheduleExists`, `deleteJobSchedule`, `getJobSchedule`, `updateJobSchedule`, `replaceJobSchedule`, `disableJobSchedule`, `enableJobSchedule`, `terminateJobSchedule`, `deleteTask`, `getTask`, `replaceTask`, `terminateTask`, and `reactivateTask`.
 
 ## 1.0.0-beta.3 (2024-10-31)
 

sdk/batch/azure-compute-batch/README.md

@@ -161,17 +161,14 @@ batchClient.createTask(jobId, taskToCreate);
 
 Error handling
 
-When a call to the batch service fails the response from that call will contain a BatchError object in the body of the response.  In the AZURE-COMPUTE-BATCH SDK when an api method is called and a failure from the server occurs the sdk will throw a HttpResponseException exception.  You can use the helper method BatchError.fromException() to extract out the BatchError object. 
+When a call to the batch service fails the response from that call will contain a BatchError object in the body of the response.  In the AZURE-COMPUTE-BATCH SDK when an api method is called and a failure from the server occurs the sdk will throw a HttpResponseException exception.  You can use the helper method BatchError.fromException() to extract out the BatchError object.
 
 ```java
-try(
-
+try {
     BatchPool pool = batchClient.getPool("poolthatdoesnotexist");
-
 } catch (HttpResponseException err) {
-
     BatchError batchError = BatchError.fromException(err);
-    Assertions.assertEquals("PoolNotFound", error.getCode());
+    Assertions.assertEquals("PoolNotFound", batchError.getCode());
 }
 ```
 

sdk/batch/azure-compute-batch/src/main/java/com/azure/compute/batch/BatchAsyncClient.java

@@ -14,7 +14,6 @@
 import com.azure.core.credential.AzureNamedKeyCredential;
 import com.azure.core.credential.TokenCredential;
 import com.azure.core.http.HttpClient;
-import com.azure.core.http.HttpHeaderName;
 import com.azure.core.http.HttpHeaders;
 import com.azure.core.http.HttpPipeline;
 import com.azure.core.http.HttpPipelineBuilder;
@@ -281,6 +280,13 @@ private BatchClientImpl buildInnerClient() {
         return client;
     }
 
+    @Generated
+    private void validateClient() {
+        // This method is invoked from 'buildInnerClient'/'buildClient' method.
+        // Developer can customize this method, to validate that the necessary conditions are met for the new client.
+        Objects.requireNonNull(endpoint, "'endpoint' cannot be null.");
+    }
+
     private HttpPipeline createHttpPipeline() {
         Configuration buildConfiguration
             = (configuration == null) ? Configuration.getGlobalConfiguration() : configuration;
@@ -293,10 +299,8 @@ private HttpPipeline createHttpPipeline() {
         policies.add(new UserAgentPolicy(applicationId, clientName, clientVersion, buildConfiguration));
         policies.add(new RequestIdPolicy("client-request-id"));
         policies.add(new AddHeadersFromContextPolicy());
-        HttpHeaders headers = new HttpHeaders();
-        localClientOptions.getHeaders()
-            .forEach(header -> headers.set(HttpHeaderName.fromString(header.getName()), header.getValue()));
-        if (headers.getSize() > 0) {
+        HttpHeaders headers = CoreUtils.createHttpHeadersFromClientOptions(localClientOptions);
+        if (headers != null) {
             policies.add(new AddHeadersPolicy(headers));
         }
         this.pipelinePolicies.stream()
@@ -314,7 +318,7 @@ private HttpPipeline createHttpPipeline() {
             .filter(p -> p.getPipelinePosition() == HttpPipelinePosition.PER_RETRY)
             .forEach(p -> policies.add(p));
         HttpPolicyProviders.addAfterRetryPolicies(policies);
-        policies.add(new HttpLoggingPolicy(httpLogOptions));
+        policies.add(new HttpLoggingPolicy(localHttpLogOptions));
         HttpPipeline httpPipeline = new HttpPipelineBuilder().policies(policies.toArray(new HttpPipelinePolicy[0]))
             .httpClient(httpClient)
             .clientOptions(localClientOptions)
@@ -343,11 +347,4 @@ public BatchClient buildClient() {
     }
 
     private static final ClientLogger LOGGER = new ClientLogger(BatchClientBuilder.class);
-
-    @Generated
-    private void validateClient() {
-        // This method is invoked from 'buildInnerClient'/'buildClient' method.
-        // Developer can customize this method, to validate that the necessary conditions are met for the new client.
-        Objects.requireNonNull(endpoint, "'endpoint' cannot be null.");
-    }
 }