[engsys] upgrade dependency glob version to ^9.0.0 (Azure#25170)

- react to api changes
- `@types/glob` is no longer needed
- remove unused dependencies for widget-tools

Author: jeremymeng

common/config/rush/pnpm-lock.yaml

@@ -72,14 +72,13 @@
     "@types/eslint": "~8.4.0",
     "@types/estree": "~1.0.0",
     "eslint-config-prettier": "^8.0.0",
-    "glob": "^8.0.0",
+    "glob": "^9.0.0",
     "json-schema": "^0.4.0",
     "typescript": "~4.8.0",
     "tslib": "^2.2.0"
   },
   "devDependencies": {
     "@types/chai": "^4.1.6",
-    "@types/glob": "^8.0.0",
     "@types/json-schema": "^7.0.6",
     "@types/mocha": "^7.0.2",
     "@types/node": "^14.0.0",

common/tools/eslint-plugin-azure-sdk/package.json

@@ -12,7 +12,7 @@ import { Node } from "estree";
 import { ParserWeakMapESTreeToTSNode } from "@typescript-eslint/typescript-estree/dist/parser-options";
 import { Rule } from "eslint";
 import { TypeChecker } from "typescript";
-import { sync as globSync } from "glob";
+import { globSync } from "glob";
 import { readFileSync } from "fs";
 import { relative } from "path";
 

common/tools/eslint-plugin-azure-sdk/src/rules/ts-doc-internal.ts

@@ -17,7 +17,6 @@ function _interopDefaultLegacy (e) { return e && typeof e === 'object' && 'defau
 var inquirer__default = /*#__PURE__*/_interopDefaultLegacy(inquirer);
 var Parser__default = /*#__PURE__*/_interopDefaultLegacy(Parser);
 var chalk__default = /*#__PURE__*/_interopDefaultLegacy(chalk);
-var glob__default = /*#__PURE__*/_interopDefaultLegacy(glob);
 var mustache__default = /*#__PURE__*/_interopDefaultLegacy(mustache);
 
 // Copyright (c) Microsoft Corporation.
@@ -835,14 +834,11 @@ async function getTemplates(template) {
     return [...sharedFiles, ...templateFiles];
 }
 async function getFiles(path) {
-    return new Promise((resolve, reject) => {
-        glob__default["default"](path, { dot: true }, (error, matches) => {
-            if (error) {
-                reject(error);
-            }
-            resolve(matches);
-        });
-    });
+    // Starting from glob v8 `\` is only used as an escape character, and never as a path separator in glob patterns.
+    // Glob pattern paths must use forward-slashes as path separators.
+    // See https://github.com/isaacs/node-glob/blob/af57da21c7722bb6edb687ccd4ad3b99d3e7a333/changelog.md#80
+    const normalizedPath = path.replace(/\\/g, "/");
+    return glob.glob(normalizedPath, { dot: true });
 }
 
 // Copyright (c) Microsoft Corporation.

sdk/apimanagement/api-management-custom-widgets-scaffolder/bin/execute.js

@@ -67,7 +67,6 @@
     "@types/chai": "^4.1.6",
     "@types/mocha": "^7.0.2",
     "@types/node": "^14.0.0",
-    "@types/glob": "^8.0.0",
     "@types/inquirer": "^8.2.1",
     "@types/yargs": "^17.0.10",
     "@types/yargs-parser": "^21.0.0",
@@ -92,7 +91,7 @@
   "dependencies": {
     "mustache": "^4.2.0",
     "prettier": "^2.5.1",
-    "glob": "^8.0.0",
+    "glob": "^9.0.0",
     "tslib": "^2.2.0",
     "typescript": "~4.8.0",
     "chalk": "^4.1.2",

sdk/apimanagement/api-management-custom-widgets-scaffolder/package.json

@@ -2,7 +2,7 @@
 // Licensed under the MIT license.
 
 import { ScaffoldTech } from "./scaffolding";
-import glob from "glob";
+import { glob } from "glob";
 import { join as pathJoin } from "path";
 
 export async function getTemplates(template: ScaffoldTech): Promise<string[]> {
@@ -20,12 +20,5 @@ async function getFiles(path: string): Promise<string[]> {
   // Glob pattern paths must use forward-slashes as path separators.
   // See https://github.com/isaacs/node-glob/blob/af57da21c7722bb6edb687ccd4ad3b99d3e7a333/changelog.md#80
   const normalizedPath = path.replace(/\\/g, "/");
-  return new Promise((resolve, reject) => {
-    glob(normalizedPath, { dot: true }, (error, matches) => {
-      if (error) {
-        reject(error);
-      }
-      resolve(matches);
-    });
-  });
+  return glob(normalizedPath, { dot: true });
 }

sdk/apimanagement/api-management-custom-widgets-scaffolder/src/getTemplates.ts

@@ -64,7 +64,6 @@
     "@types/mocha": "^7.0.2",
     "@types/mime": "^3.0.1",
     "@types/node": "^14.0.0",
-    "@types/glob": "^8.0.0",
     "@types/yargs": "^17.0.10",
     "@types/yargs-parser": "^21.0.0",
     "@azure/eslint-plugin-azure-sdk": "^3.0.0",
@@ -101,7 +100,6 @@
     "mime": "^3.0.0",
     "mustache": "^4.2.0",
     "prettier": "^2.5.1",
-    "glob": "^8.0.0",
     "tslib": "^2.2.0",
     "rollup": "^2.66.1",
     "@rollup/plugin-node-resolve": "^13.1.3"