Support list non-resource method in parent resource (Azure#53466)

* Support scenario list non-resource method in parent resource

* Update eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Utilities/ResourceMetadataExtensions.cs

Co-authored-by: Copilot <[email protected]>

* regen

* add TODO

---------

Co-authored-by: Copilot <[email protected]>

Author: live1206

eng/packages/http-client-csharp-mgmt/emitter/src/resource-detection.ts

@@ -75,6 +75,7 @@ export async function updateClients(
         resourceScope: ResourceScope.Tenant, // temporary default to Tenant, will be properly set later after methods are populated
         methods: [],
         parentResourceId: undefined, // this will be populated later
+        parentResourceModelId: undefined,
         resourceName: m.name
       } as ResourceMetadata
     ])
@@ -132,6 +133,7 @@ export async function updateClients(
       metadata.parentResourceId = resourceModelToMetadataMap.get(
         parentResourceModelId
       )?.resourceIdPattern;
+      metadata.parentResourceModelId = parentResourceModelId;
     }
 
     // figure out the resourceScope of all resource methods
@@ -149,6 +151,17 @@ export async function updateClients(
     }
   }
 
+  // after the parentResourceId and resource scopes are populated, we can reorganize the metadata that is missing resourceIdPattern
+  for (const [modelId, metadata] of resourceModelToMetadataMap) {
+    // TODO: handle the case where there is no parentResourceId but resourceIdPattern is missing
+    if (metadata.resourceIdPattern === "" && metadata.parentResourceModelId) {
+      resourceModelToMetadataMap.get(metadata.parentResourceModelId)?.methods.push(
+        ...metadata.methods
+      );
+      resourceModelToMetadataMap.delete(modelId);
+    }
+  }
+
   // the last step, add the decorator to the resource model
   for (const model of resourceModels) {
     const metadata = resourceModelToMetadataMap.get(

eng/packages/http-client-csharp-mgmt/emitter/src/resource-metadata.ts

@@ -42,6 +42,7 @@ export interface ResourceMetadata {
   methods: ResourceMethod[];
   resourceScope: ResourceScope;
   parentResourceId?: string;
+  parentResourceModelId? : string;
   singletonResourceName?: string;
   resourceName: string;
 }

eng/packages/http-client-csharp-mgmt/emitter/test/resource-detection.test.ts

@@ -1049,4 +1049,102 @@ interface Employees {
     strictEqual(getMethodEntry.kind, "Get");
     strictEqual(getMethodEntry.operationScope, ResourceScope.Subscription);
   });
+
+  it("parent-child resource with list operation", async () => {
+    const program = await typeSpecCompile(
+      `
+/** An Employee parent resource */
+model EmployeeParent is TrackedResource<EmployeeParentProperties> {
+  ...ResourceNameParameter<EmployeeParent>;
+}
+
+/** Employee parent properties */
+model EmployeeParentProperties {
+  /** Name of parent */
+  name?: string;
+}
+
+/** An Employee resource */
+@parentResource(EmployeeParent)
+model Employee is TrackedResource<EmployeeProperties> {
+  ...ResourceNameParameter<Employee>;
+}
+
+/** Employee properties */
+model EmployeeProperties {
+  /** Age of employee */
+  age?: int32;
+
+  /** City of employee */
+  city?: string;
+}
+
+interface Operations extends Azure.ResourceManager.Operations {}
+
+@armResourceOperations
+interface EmployeeParents {
+  get is ArmResourceRead<EmployeeParent>;
+}
+
+@armResourceOperations
+interface Employees {
+  listByParent is ArmResourceListByParent<Employee>;
+}
+`,
+      runner
+    );
+    const context = createEmitterContext(program);
+    const sdkContext = await createCSharpSdkContext(context);
+    const root = createModel(sdkContext);
+    updateClients(root, sdkContext);
+    
+    const employeeClient = getAllClients(root).find((c) => c.name === "Employees");
+    ok(employeeClient);
+    const employeeParentClient = getAllClients(root).find((c) => c.name === "EmployeeParents");
+    ok(employeeParentClient);
+    
+    const employeeModel = root.models.find((m) => m.name === "Employee");
+    ok(employeeModel);
+    const employeeParentModel = root.models.find((m) => m.name === "EmployeeParent");
+    ok(employeeParentModel);
+    
+    const listByParentMethod = employeeClient.methods.find((m) => m.name === "listByParent");
+    ok(listByParentMethod);
+    const getMethod = employeeParentClient.methods.find((m) => m.name === "get");
+    ok(getMethod);
+
+    // Validate Employee resource metadata should be null (no CRUD operations)
+    const employeeResourceMetadataDecorator = employeeModel.decorators?.find(
+      (d) => d.name === resourceMetadata
+    );
+    strictEqual(employeeResourceMetadataDecorator, undefined, "Employee should not have resource metadata decorator without CRUD operations");
+
+    // Validate EmployeeParent resource metadata
+    const parentResourceMetadataDecorator = employeeParentModel.decorators?.find(
+      (d) => d.name === resourceMetadata
+    );
+    ok(parentResourceMetadataDecorator);
+    ok(parentResourceMetadataDecorator.arguments);
+    strictEqual(
+      parentResourceMetadataDecorator.arguments.resourceIdPattern,
+      "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContosoProviderHub/employeeParents/{employeeParentName}"
+    );
+    strictEqual(
+      parentResourceMetadataDecorator.arguments.resourceType,
+      "Microsoft.ContosoProviderHub/employeeParents"
+    );
+    strictEqual(
+      parentResourceMetadataDecorator.arguments.resourceScope,
+      "ResourceGroup"
+    );
+    strictEqual(parentResourceMetadataDecorator.arguments.parentResourceId, undefined);
+    strictEqual(parentResourceMetadataDecorator.arguments.resourceName, "EmployeeParent");
+    strictEqual(parentResourceMetadataDecorator.arguments.methods.length, 2);
+
+    // Validate EmployeeParent listByParent method
+    const listByParentEntry = parentResourceMetadataDecorator.arguments.methods.find(
+      (m: any) => m.methodId === listByParentMethod.crossLanguageDefinitionId
+    );
+    ok(listByParentEntry);
+  });
 });

eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Utilities/ResourceMetadataExtensions.cs

@@ -86,9 +86,14 @@ public static ResourceMethodCategory CategorizeMethods(this ResourceMetadata res
                         methodsInResource.Add(method);
                         break;
                     case ResourceOperationKind.List:
+                        // list method goes to resource if the method's resource scope matches the resource's ID pattern
+                        if (method.ResourceScope == resourceMetadata.ResourceIdPattern)
+                        {
+                            methodsInResource.Add(method);
+                        }
                         // list methods might go to the collection or the extension
                         // when the resource has a parent
-                        if (resourceMetadata.ParentResourceId is not null)
+                        else if (resourceMetadata.ParentResourceId is not null)
                         {
                             if (method.ResourceScope == resourceMetadata.ParentResourceId)
                             {

eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/bar.tsp

@@ -130,3 +130,23 @@ interface BarQuotaOperations {
   get is ArmResourceRead<BarQuotaResource>;
   update is ArmCustomPatchAsync<BarQuotaResource, BarQuotaResource>;
 }
+
+/** An Employee resource */
+@parentResource(Bar)
+model Employee is TrackedResource<EmployeeProperties> {
+  ...ResourceNameParameter<Employee>;
+}
+
+/** Employee properties */
+model EmployeeProperties {
+  /** Age of employee */
+  age?: int32;
+
+  /** City of employee */
+  city?: string;
+}
+
+@armResourceOperations
+interface Employees {
+  listByParent is ArmResourceListByParent<Employee>;
+}