Skip to content

Commit 39b25e1

Browse files
Update Event Processor to condition login (Azure#41321)
- We always had 2 jobs because the condition didn't work for login step it seems that GH has fixed that issue so we can now just condition the step. - Hard code the non-secret values for the login so it is easier to on-board new usages Co-authored-by: Wes Haggard <[email protected]>
1 parent 27d295a commit 39b25e1

File tree

1 file changed

+5
-63
lines changed

1 file changed

+5
-63
lines changed

.github/workflows/event-processor.yml

Lines changed: 5 additions & 63 deletions
Original file line numberDiff line numberDiff line change
@@ -30,16 +30,17 @@ jobs:
3030
contents: read
3131
name: Handle ${{ github.event_name }} ${{ github.event.action }} event with azure login
3232
runs-on: ubuntu-latest
33-
if: ${{ github.event_name == 'issues' && github.event.action == 'opened' }}
3433
steps:
3534
- name: 'Az CLI login'
3635
uses: azure/login@v2
36+
if: ${{ github.event_name == 'issues' && github.event.action == 'opened' }}
3737
with:
38-
client-id: ${{ secrets.AZURE_CLIENT_ID }}
39-
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
40-
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
38+
client-id: a6dd2dfe-7352-41a7-9020-05301c3bca1a
39+
tenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
40+
allow-no-subscriptions: true
4141

4242
- name: 'Run Azure CLI commands'
43+
if: ${{ github.event_name == 'issues' && github.event.action == 'opened' }}
4344
run: |
4445
LABEL_SERVICE_API_KEY=$(az keyvault secret show \
4546
--vault-name issue-labeler \
@@ -101,62 +102,3 @@ jobs:
101102
with:
102103
name: event
103104
path: ${{ github.event_path }}
104-
105-
event-handler:
106-
permissions:
107-
issues: write
108-
pull-requests: write
109-
name: Handle ${{ github.event_name }} ${{ github.event.action }} event
110-
runs-on: ubuntu-latest
111-
if: ${{ github.event_name != 'issues' || github.event.action != 'opened' }}
112-
steps:
113-
# To run github-event-processor built from source, for testing purposes, uncomment everything
114-
# in between the Start/End-Build From Source comments and comment everything in between the
115-
# Start/End-Install comments
116-
# Start-Install
117-
- name: Install GitHub Event Processor
118-
run: >
119-
dotnet tool install
120-
Azure.Sdk.Tools.GitHubEventProcessor
121-
--version 1.0.0-dev.20250314.4
122-
--add-source https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-net/nuget/v3/index.json
123-
--global
124-
shell: bash
125-
# End-Install
126-
127-
# Testing checkout of sources from the Azure/azure-sdk-tools repository
128-
# The ref: is the SHA from the pull request in that repository or the
129-
# refs/pull/<PRNumber>/merge for the latest on any given PR. If the repository
130-
# is a fork eg. <User>/azure-sdk-tools then the repository down below will
131-
# need to point to that fork
132-
# Start-Build
133-
# - name: Checkout tools repo for GitHub Event Processor sources
134-
# uses: actions/checkout@v3
135-
# with:
136-
# repository: Azure/azure-sdk-tools
137-
# path: azure-sdk-tools
138-
# ref: <refs/pull/<PRNumber>/merge> or <sha>
139-
140-
# - name: Build and install GitHubEventProcessor from sources
141-
# run: |
142-
# dotnet pack
143-
# dotnet tool install --global --prerelease --add-source ../../../artifacts/packages/Debug Azure.Sdk.Tools.GitHubEventProcessor
144-
# shell: bash
145-
# working-directory: azure-sdk-tools/tools/github-event-processor/Azure.Sdk.Tools.GitHubEventProcessor
146-
# End-Build
147-
148-
- name: Process Action Event
149-
run: |
150-
github-event-processor ${{ github.event_name }} ${{ github.event_path }}
151-
shell: bash
152-
env:
153-
# This is a temporary secret generated by github
154-
# https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret
155-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
156-
157-
- name: Archive github event data
158-
uses: actions/upload-artifact@v4
159-
if: always()
160-
with:
161-
name: event
162-
path: ${{ github.event_path }}

0 commit comments

Comments
 (0)