Open
Conversation
- minor code clean
- removed the template from license - added one variable per line - documented the enums - updated the doc folder as per `joint_trajectory_controller`
Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
- renamed service_buffer_ to gripper_service_buffer_
Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
updated the param for yaml
… is not required.
|
@Nibanovic, all pull requests must be targeted towards the |
|
This pull request is in conflict. Could you fix it @Nibanovic? |
|
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
destogl
force-pushed
the
io_gripper_controller
branch
from
bf9723f to
0364c71
Compare
|
This pull request is in conflict. Could you fix it @Nibanovic? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gpio controller won't compile with C++17 due to this type:
std_shared does nto have a trivial copy constructor which can be handled with C++17
atomic.In this PR, I've opted for using
realtime_tools::RealtimeThreadSafeBoxfor access to the string.COLCON_INGORE
io_gripper_controllerConsider deleting io_gripper_controller from the repo, it is empty and this replaces it.