SO-6485: Propagate total component counts in BranchCompareResult#1419
Open
SO-6485: Propagate total component counts in BranchCompareResult#1419
Conversation
This functionality was removed in commit d27a406 but is still needed when the itemized changes can not be sent to clients in their entirety due to resource limitations.
apeteri
commented
Oct 10, 2025
Comment on lines
+147
to
+150
| // These descriptions are registered as changed components for some reason, possibly due to language refset members | ||
| assertThat(compare.getChangedComponents()) | ||
| .hasSize(1) | ||
| .containsAnyElementsOf(newDescriptionIds); |
Member
Author
There was a problem hiding this comment.
This test gives a suprising result here but we haven't figured it out yet. @cmark any guesses?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 9.x #1419 +/- ##
============================================
+ Coverage 64.40% 64.43% +0.03%
- Complexity 12791 12809 +18
============================================
Files 1620 1620
Lines 57761 57815 +54
Branches 5682 5685 +3
============================================
+ Hits 37199 37254 +55
Misses 18189 18189
+ Partials 2373 2372 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nagyo
approved these changes
Oct 13, 2025
Member
nagyo
left a comment
nagyo
left a comment
There was a problem hiding this comment.
Other than the flaky test, the change itself looks good to me!
AAAlinaaa
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://snowowl.atlassian.net/browse/SO-6485