This repository was archived by the owner on Oct 15, 2022. It is now read-only.
Conversation
Open
Owner
Author
|
Update: #43 would fix all bash related issues. The dotfile issue doesn’t seem to be an issue. You just do it. The only concern then will be about packaging since a package on mac contains everything (client and server). I don’t know how a package on windows works. Building the client for windows should then work just fine. The only issue being left is how to run the server on windows since there is no native support possible right now. Options are WSL or external. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I skimmed through the code and commented with "! WIN“ on all lines which I think hold back windows compatibility. Unfortunately I have no idea how to do things on windows so someone with more knowledge would be great help.
To see my notes check af3cc23