fix: Use resolve instead of evaluate#225
Merged
nicolo-ribaudo merged 3 commits intobabel:mainfrom Mar 2, 2025
Merged
Conversation
nicolo-ribaudo
approved these changes
Mar 1, 2025
Member
nicolo-ribaudo
left a comment
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
Btw, could you change the comment in the Babel repo for resolve? The current one (Resolve a "pointer" NodePath to it's absolute path.) doesn't make much sense.
JLHwung
approved these changes
Mar 1, 2025
liuxingbaoyu
commented
Mar 8, 2025
| } | ||
| const resolved = path.resolve(); | ||
| if (resolved.isIdentifier()) { | ||
| return resolved.node.name; |
Member
Author
There was a problem hiding this comment.
While working on #225 (review) I realized there is a observable difference.
var b = Math;
b.f16round();
Now it won't return Math, maybe I should open a PR to restore this behavior?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently relies on buggy behavior.
babel/babel#17156