Skip to content

Support for Babelfish v.5.2.0 (17.5) and v.4.6.0 (16.9)#145

Merged
R4hul04 merged 6 commits intomainfrom
2025_06
Jun 3, 2025
Merged

Support for Babelfish v.5.2.0 (17.5) and v.4.6.0 (16.9)#145
R4hul04 merged 6 commits intomainfrom
2025_06

Conversation

@manisha-deshpande
Copy link
Copy Markdown
Collaborator

@manisha-deshpande manisha-deshpande commented May 7, 2025

Description

  • Added support for Babelfish v.5.2.0 (17.5) and v.4.6.0 (16.9)
  • Updated BabelfishFeatures.cfg to detect newly supported features ALTER VIEW, UNPIVOT, Geospatial functions (STDimension, STDisjoint, STIntersects, STIsClosed, STIsEmpty, STIsValid) in 5.2.0, 4.6.0 and upward minor versions.
  • updated java code to handle error scenario: ALTER VIEW on VIEWs with dependent triggers.

Issues Resolved

BABEL-5786: Add support for Babelfish v.5.2.0 and v.4.6.0.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

public static final String thisProgVersion = "2025-04";
public static final String thisProgVersionDate = "April 2025";
public static final String thisProgVersion = "2025-06";
public static final String thisProgVersionDate = "June 2025";
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How sure are we that this is not going to be in May 2025 or July 2025?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release is scheduled for June 1st week. Will update timestamp incase of delays.

Updated time and metadata config for new minor version releases of
babelfish v5.2.0 (PG 17.5) and v4.6.0 (PG 16.9). Added support for newly
supported features ALTER VIEW and UNPIVOT.

Task: BABEL-5786
Signed-off-by: Manisha Deshpande <mmdeshp@amazon.com>
Signed-off-by: Manisha Deshpande <mmdeshp@amazon.com>
Added support for geospatial function calls: STDimension, STDisjoint,
STIntersects, STIsClosed, STIsEmpty, STIsValid

Task: BABEL-5786
Signed-off-by: Manisha Deshpande <mmdeshp@amazon.com>
Signed-off-by: Rahul Parande <rparande@amazon.com>

String kwd = "CREATE";
String status = u.Supported;
String hasTrigger = null;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use boolean instead of string


String trigName = lookupTrigOnView(viewName);
if (!trigName.isEmpty()) {
status = u.NotSupported;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have to add an item to the .cfg file and specifically test for that. you cannot just decide here that it is not supported

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added list item - View (representing Alter view) and Trigger (representing Alter view with trigger) in .cfg file

Signed-off-by: Rahul Parande <rparande@amazon.com>
@R4hul04 R4hul04 requested review from AdnaneKhan and robverschoor and removed request for AdnaneKhan May 27, 2025 19:57
@R4hul04 R4hul04 marked this pull request as ready for review May 29, 2025 00:27
Updated from actions/checkout@v2 to actions/checkout@v3 and 
actions/setup-java@v2 to actions/setup-java@v3.
Updated distribution : 'adopt' to 'temurin'
@R4hul04 R4hul04 merged commit 0c73b85 into main Jun 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants