Include unique constraints metadata in sys.objects view#3658
Merged
jsudrik merged 3 commits intobabelfish-for-postgresql:BABEL_5_X_DEVfrom Apr 8, 2025
Merged
Conversation
This commit rectifies the type check for fetching metadata of both primary key and unique constraints from sys.key_constraints catalog inorder to correctly populate sys.objects view. Task: BABEL-5712 Signed-off-by: Roshan Kanwar <rskanwar@amazon.com>
shalinilohia50
approved these changes
Apr 7, 2025
KushaalShroff
approved these changes
Apr 7, 2025
KushaalShroff
requested changes
Apr 7, 2025
KushaalShroff
approved these changes
Apr 8, 2025
jsudrik
merged commit 5360b0e
into
babelfish-for-postgresql:BABEL_5_X_DEV
47 checks passed
roshan0708
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Apr 8, 2025
…r-postgresql#3658) * Include unique constraints metadata in sys.objects view This commit rectifies the type check for fetching metadata of both primary key and unique constraints from sys.key_constraints catalog inorder to correctly populate sys.objects view. Task: BABEL-5712 Signed-off-by: Roshan Kanwar <rskanwar@amazon.com>
1 task
shardgupta
pushed a commit
that referenced
this pull request
Apr 8, 2025
This commit rectifies the type check for fetching metadata of both primary key and unique constraints from sys.key_constraints catalog inorder to correctly populate sys.objects view. Task: BABEL-5712 Signed-off-by: Roshan Kanwar <rskanwar@amazon.com>
roshan0708
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Apr 15, 2025
…r-postgresql#3658) * Include unique constraints metadata in sys.objects view This commit rectifies the type check for fetching metadata of both primary key and unique constraints from sys.key_constraints catalog inorder to correctly populate sys.objects view. Task: BABEL-5712 Signed-off-by: Roshan Kanwar <rskanwar@amazon.com> (cherry picked from commit 5360b0e)
roshan0708
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Apr 15, 2025
…r-postgresql#3658) (babelfish-for-postgresql#3660) This commit rectifies the type check for fetching metadata of both primary key and unique constraints from sys.key_constraints catalog inorder to correctly populate sys.objects view. Task: BABEL-5712 Signed-off-by: Roshan Kanwar <rskanwar@amazon.com> (cherry picked from commit 5d5f6d8)
1 task
jsudrik
pushed a commit
that referenced
this pull request
Apr 16, 2025
* Include unique constraints metadata in sys.objects view This commit rectifies the type check for fetching metadata of both primary key and unique constraints from sys.key_constraints catalog inorder to correctly populate sys.objects view. Task: BABEL-5712 Signed-off-by: Roshan Kanwar <rskanwar@amazon.com> (cherry picked from commit 5360b0e)
sharathbp
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Sep 22, 2025
…r-postgresql#3658) (babelfish-for-postgresql#3660) This commit rectifies the type check for fetching metadata of both primary key and unique constraints from sys.key_constraints catalog inorder to correctly populate sys.objects view. Task: BABEL-5712 Signed-off-by: Roshan Kanwar <rskanwar@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit rectifies the type check for fetching metadata of both primary key and unique constraints from sys.key_constraints catalog inorder to correctly populate sys.objects view.
Issues Resolved
BABEL-5712
Test Scenarios Covered
Use case based - y
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.