Implement needs_fmgr_hook#3779
Closed
tanscorpio7 wants to merge 3 commits intobabelfish-for-postgresql:BABEL_5_X_DEVfrom
Closed
Implement needs_fmgr_hook#3779tanscorpio7 wants to merge 3 commits intobabelfish-for-postgresql:BABEL_5_X_DEVfrom
tanscorpio7 wants to merge 3 commits intobabelfish-for-postgresql:BABEL_5_X_DEVfrom
Conversation
Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>
Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>
Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement needs_fmgr_hook to force fmgr_security_definer
for all routines. We need to force it since we change sql_dialect
before and after every function execution based on their lang.
Without this fix we are not chaning the sql_dialect for
inlinable functions and running into unexpected erros.
Issues Resolved
#3071
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.