Add Try-Catch handling during ResetTDSConnection and TDS_INIT_PHASE#3787
Merged
shardgupta merged 1 commit intobabelfish-for-postgresql:BABEL_2_X_DEVfrom May 28, 2025
Merged
Conversation
…abelfish-for-postgresql#3784) This commit wraps ResetTDSConnection and TDS_INIT_PHASE within a Try-Catch block to handle corrupted memory and errors due to uncommon conditions such as OOM resulting in a crash. We will now terminate the connection by throwing a fatal error upon catching such issues. Task: BABEL- 4584 Authored-by: Anikait Agrawal agraani@amazon.com Signed-off-by: Anikait Agrawal agraani@amazon.com
tanscorpio7
approved these changes
May 28, 2025
shardgupta
approved these changes
May 28, 2025
shardgupta
merged commit 458945d
into
babelfish-for-postgresql:BABEL_2_X_DEV
30 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit wraps ResetTDSConnection and TDS_INIT_PHASE within a Try-Catch block to handle corrupted memory and errors due to uncommon conditions such as OOM resulting in a crash. We will now terminate the connection by throwing a fatal error upon catching such issues.
cherry-picked: #3784
Task: BABEL- 4584
Authored-by: Anikait Agrawal agraani@amazon.com
Signed-off-by: Anikait Agrawal agraani@amazon.com
Testing Details
Tested locally by throwing an error during ResetTdsConnection, which earlier resulted in a crash, now fixed by terminating the connection.
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.