Typmod handling for functions expression with numeric.#3851
Closed
Yvinayak07 wants to merge 19 commits intobabelfish-for-postgresql:BABEL_5_X_DEVfrom
Closed
Typmod handling for functions expression with numeric.#3851Yvinayak07 wants to merge 19 commits intobabelfish-for-postgresql:BABEL_5_X_DEVfrom
Yvinayak07 wants to merge 19 commits intobabelfish-for-postgresql:BABEL_5_X_DEVfrom
Conversation
added 7 commits
June 19, 2025 04:29
Signed-off-by: yashneet vinayak <yashneet@amazon.com>
Signed-off-by: yashneet vinayak <yashneet@amazon.com>
Signed-off-by: yashneet vinayak <yashneet@amazon.com>
Signed-off-by: yashneet vinayak <yashneet@amazon.com>
Signed-off-by: yashneet vinayak <yashneet@amazon.com>
Collaborator
Pull Request Test Coverage Report for Build 16142159261Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
added 12 commits
June 20, 2025 04:24
Signed-off-by: yashneet vinayak <yashneet@amazon.com>
Signed-off-by: yashneet vinayak <yashneet@amazon.com>
Signed-off-by: yashneet vinayak <yashneet@amazon.com>
Signed-off-by: yashneet vinayak <yashneet@amazon.com>
Signed-off-by: yashneet vinayak <yashneet@amazon.com>
Signed-off-by: yashneet vinayak <yashneet@amazon.com>
Signed-off-by: yashneet vinayak <yashneet@amazon.com>
Signed-off-by: yashneet vinayak <yashneet@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
In
resolve_numeric_typmod_from_expwe missed the handling for typmod calculation for some mathematical functions in function expression likeROUND(), POWER(), CEILING(), FLOOR(), SIGN(), ABS(), DEGREES(), RADAINS(), SCOPE_IDENTITY(), IDENT_SEED(), IDENT_INCR(), IDENT_CURRENT().2. Changes made to fix the issues
Added handling for
ROUND(), POWER(), CEILING(), FLOOR(), SIGN(), ABS(), DEGREES(), RADAINS(), SCOPE_IDENTITY(), IDENT_SEED(), IDENT_INCR(), IDENT_CURRENT()mathematical functions inT_FuncExprnodeIssues Resolved
Task: BABEL-5666
Authored-by: yashneet vinayak yashneet@amazon.com
Signed-off-by: yashneet vinayak yashneet@amazon.com
Test Scenarios Covered
Use case based - YES
Boundary conditions - YES
Arbitrary inputs - YES
Negative test cases - YES
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.