Fixed error while using PosgreSQL reserved keyword in cursor operations#3866
Merged
shardgupta merged 7 commits intobabelfish-for-postgresql:BABEL_5_X_DEVfrom Jun 26, 2025
Conversation
Signed-off-by: Shard Gupta <shardga@amazon.com>
Collaborator
Pull Request Test Coverage Report for Build 15900333032Details
💛 - Coveralls |
shardgupta
requested review from
KushaalShroff and
tanscorpio7
and removed request for
KushaalShroff
tanscorpio7
requested changes
Jun 22, 2025
shardgupta
force-pushed
the
curser-in-prepared-st
branch
from
37276b7 to
66ad5e1
Compare
comments and code refactoring Signed-off-by: Shard Gupta <shardga@amazon.com>
shardgupta
force-pushed
the
curser-in-prepared-st
branch
from
66ad5e1 to
42a208d
Compare
Signed-off-by: Shard Gupta <shardga@amazon.com>
tanscorpio7
approved these changes
Jun 25, 2025
Signed-off-by: Shard Gupta <shardga@amazon.com>
KushaalShroff
requested changes
Jun 25, 2025
Signed-off-by: Shard Gupta <shardga@amazon.com>
Signed-off-by: Shard Gupta <shardga@amazon.com>
shardgupta
force-pushed
the
curser-in-prepared-st
branch
from
243622f to
c9a2e21
Compare
KushaalShroff
approved these changes
Jun 26, 2025
shardgupta
changed the title
shardgupta
merged commit e6e094c
into
babelfish-for-postgresql:BABEL_5_X_DEV
47 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During the cursor prepare, execution flow for statement is not passed through antlr parser. This causes issue when query contains PosgreSQL reserved keywords. This PR addresses this issue, along with any potential issue with query which is not compatible with PostgreSQL
Task: BABEL-5743
Signed-off-by: Shard Gupta shardga@amazon.com