Refactor sys.columns_internal for improved performance#4653
Open
rohit01010 wants to merge 2 commits intobabelfish-for-postgresql:BABEL_5_X_DEVfrom
Open
Refactor sys.columns_internal for improved performance#4653rohit01010 wants to merge 2 commits intobabelfish-for-postgresql:BABEL_5_X_DEVfrom
rohit01010 wants to merge 2 commits intobabelfish-for-postgresql:BABEL_5_X_DEVfrom
Conversation
…sys.computed_columns, sys.identity_columns and sys.syscolumns Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The sys.columns_internal was originally implemented as a function, which caused significant performance bottleneck when used by dependent system views like sys.columns, sys.computed_columns, sys.identity_columns, and sys.syscolumns. Function scans prevent filter pushdown and force the query planner to materialize all function results before applying WHERE conditions, resulting in inefficient execution plans and poor performance for metadata queries that are frequently used by applications and tools.
In this change, we converts sys.columns_internal from a function to a view that directly queries PostgreSQL system catalogs using optimized joins and filtering conditions. The refactored view enables the PostgreSQL query optimizer to create better execution plans, allows for predicate pushdown, and eliminates the function scan bottleneck while maintaining full backward compatibility and providing the same column metadata with significantly improved performance for all dependent system views.
Authored-by: Rohit Bhagat rohitbgt@amazon.com
Signed-off-by: Rohit Bhagat rohitbgt@amazon.com
Issues Resolved
BABEL-6233
Test Scenarios Covered
Use case based -
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.