Fix memory leaks in for_xml_ffunc() by adding missing regfree() calls#4663
Merged
tanscorpio7 merged 2 commits intobabelfish-for-postgresql:BABEL_6_X_DEVfrom Mar 19, 2026
Merged
Conversation
…babelfish-for-postgresql#4655) The function for_xml_ffunc() is calling regcomp() to compile regular expressions but failing to call regfree() to release the allocated memory, causing memory leaks during FOR XML Queries. This PR fixes memory leaks in the for_xml_ffunc() function by adding missing regfree() calls to properly clean up compiled regular expressions. Task: BABEL-6403 Authored-by: Rohit Bhagat rohitbgt@amazon.com
tanscorpio7
approved these changes
Mar 19, 2026
tanscorpio7
merged commit 3f465bf
into
babelfish-for-postgresql:BABEL_6_X_DEV
48 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The function for_xml_ffunc() is calling regcomp() to compile regular expressions but failing to call regfree() to release the allocated memory, causing memory leaks during FOR XML Queries.
This PR fixes memory leaks in the for_xml_ffunc() function by adding missing regfree() calls to properly clean up compiled regular expressions.
Cherry-picked from #4655
Authored-by: Rohit Bhagat rohitbgt@amazon.com
Signed-off-by: Rohit Bhagat rohitbgt@amazon.com
Issues Resolved
BABEL-6403
Test Scenarios Covered
Use case based -
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.