Materialize table_types_internal as CTE in sys.all_objects to prevent view inlining#4684
Open
RuchaSK1 wants to merge 2 commits intobabelfish-for-postgresql:BABEL_4_X_DEVfrom
Open
Conversation
added 2 commits
March 26, 2026 22:48
… view inlining Signed-off-by: Rucha Kulkarni <ruchask@amazon.com>
Signed-off-by: Rucha Kulkarni <ruchask@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The sys.all_objects view joins against sys.table_types_internal to exclude table types from the user table branches. Because table_types_internal is a plain view, the planner inlines its definition (a 4-way join across pg_type, pg_namespace, pg_class, pg_depend) and re-executes it per row inside a nested loop, causing significant performance degradation.
This change wraps table_types_internal in a materialized CTE inside sys.all_objects so it is computed once and reused.
We observed following performance improvement:
With
enable_mergejoin = on(default):SELECT OBJECTPROPERTYEX(286596, 'IsSchemaBound')SELECT COUNT(*) FROM sys.all_objectsSELECT OBJECTPROPERTYEX(34290, 'BaseType')With
enable_mergejoin = off:SELECT OBJECTPROPERTYEX(286596, 'IsSchemaBound')SELECT COUNT(*) FROM sys.all_objectsSELECT OBJECTPROPERTYEX(34290, 'BaseType')Issues Resolved
Task: BABEL-6404
Authored-by: Rucha Kulkarni ruchask@amazon.com
Signed-off-by: Rucha Kulkarni ruchask@amazon.com
Test Scenarios Covered
Use case based - Yes
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.