Skip to content
This repository was archived by the owner on Jul 20, 2025. It is now read-only.

Conversation

jrwbabylonlab
Copy link
Collaborator

@jrwbabylonlab jrwbabylonlab commented Jul 19, 2025

  1. Add default reviewer
  2. Split the high-level components into "elements" and "sections"

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restructures the codebase by moving components from the components/ directory to an elements/ directory and reorganizes the section widgets from new-design/ to sections/. The changes also refactor the FinalityProviderSubsection component to accept actionText as a prop instead of deriving it internally.

  • Moves ProvidersList, FinalityProviderLogo, and FinalityProviderItem from components to elements directory
  • Relocates section widgets from widgets/new-design/ to widgets/sections/
  • Refactors FinalityProviderSubsection to accept actionText as a prop and renames parameter from bsnId to id

Reviewed Changes

Copilot reviewed 7 out of 28 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/widgets/sections/FinalityProviderSubsection/FinalityProviderSubsection.tsx Updates import paths and adds actionText prop while removing internal logic for determining action text
src/widgets/sections/FinalityProviderSubsection/FinalityProviderSubsection.stories.tsx Updates import paths and adds actionText prop to all story configurations
src/index.tsx Updates export paths to reflect new directory structure
src/elements/ProvidersList/ProvidersList.tsx Renames parameter from bsnId to id for consistency
src/elements/FinalityProviderLogo/FinalityProviderLogo.tsx Updates import path for Text component
src/elements/FinalityProviderItem/FinalityProviderItem.tsx Updates import paths and renames parameter from bsnId to id
.github/CODEOWNERS Adds code ownership configuration
Comments suppressed due to low confidence (8)

src/widgets/sections/FinalityProviderSubsection/FinalityProviderSubsection.stories.tsx:96

  • The parameter name 'bsnId' is inconsistent with the updated component interface which now uses 'id'. This should be renamed to 'id' to match the component's Props interface.
    onRemove: (bsnId?: string) => void;

src/widgets/sections/FinalityProviderSubsection/FinalityProviderSubsection.stories.tsx:113

  • The parameter name 'bsnId' is inconsistent with the updated component interface which now uses 'id'. This should be renamed to 'id' to match the component's Props interface.
    onRemove: (bsnId?: string) => void;

src/widgets/sections/FinalityProviderSubsection/FinalityProviderSubsection.stories.tsx:130

  • The parameter name 'bsnId' is inconsistent with the updated component interface which now uses 'id'. This should be renamed to 'id' to match the component's Props interface.
    onRemove: (bsnId?: string) => void;

src/widgets/sections/FinalityProviderSubsection/FinalityProviderSubsection.stories.tsx:147

  • The parameter name 'bsnId' is inconsistent with the updated component interface which now uses 'id'. This should be renamed to 'id' to match the component's Props interface.
    onRemove: (bsnId?: string) => void;

src/widgets/sections/FinalityProviderSubsection/FinalityProviderSubsection.stories.tsx:164

  • The parameter name 'bsnId' is inconsistent with the updated component interface which now uses 'id'. This should be renamed to 'id' to match the component's Props interface.
    onRemove: (bsnId?: string) => void;

src/widgets/sections/FinalityProviderSubsection/FinalityProviderSubsection.stories.tsx:181

  • The parameter name 'bsnId' is inconsistent with the updated component interface which now uses 'id'. This should be renamed to 'id' to match the component's Props interface.
    onRemove: (bsnId?: string) => void;

src/widgets/sections/FinalityProviderSubsection/FinalityProviderSubsection.stories.tsx:216

  • The parameter name 'bsnId' is inconsistent with the updated component interface which now uses 'id'. This should be renamed to 'id' to match the component's Props interface.
    onRemove: (bsnId?: string) => void;

src/widgets/sections/FinalityProviderSubsection/FinalityProviderSubsection.stories.tsx:253

  • The parameter name 'bsnId' is inconsistent with the updated component interface which now uses 'id'. This should be renamed to 'id' to match the component's Props interface.
    onRemove: (bsnId?: string) => void;

@jrwbabylonlab jrwbabylonlab merged commit 5023b4b into main Jul 19, 2025
4 checks passed
@jrwbabylonlab jrwbabylonlab deleted the create-elements-sections branch July 19, 2025 06:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants