core: reduce mutable config params (#107)

## Description

This PR reduced mutable config params. `bsn_activation_height` and
`finality_signature_interval` should not be mutable

Fixes #106

## Checklist

- [x] I have updated the
[docs/SPEC.md](https://github.com/babylonlabs-io/rollup-bsn-contracts/blob/main/docs/SPEC.md)
file if this change affects the specification
- [x] I have updated the schema by running `cargo gen-schema`

Author: 0xAleksaOpacic

CHANGELOG.md

@@ -48,6 +48,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 
 ### Improvements
 
+* [#107](https://github.com/babylonlabs-io/rollup-bsn-contracts/pull/107) core: 
+  reduce mutable config params
 * [#108](https://github.com/babylonlabs-io/rollup-bsn-contracts/pull/91) feat:
   optimize public key handling by using bytes instead of hex
 * [#103](https://github.com/babylonlabs-io/rollup-bsn-contracts/pull/103) core: 

contracts/finality/schema/finality.json

@@ -336,24 +336,6 @@
           "update_config": {
             "type": "object",
             "properties": {
-              "bsn_activation_height": {
-                "description": "New BSN activation height (if provided)",
-                "type": [
-                  "integer",
-                  "null"
-                ],
-                "format": "uint64",
-                "minimum": 0.0
-              },
-              "finality_signature_interval": {
-                "description": "New finality signature interval (if provided)",
-                "type": [
-                  "integer",
-                  "null"
-                ],
-                "format": "uint64",
-                "minimum": 0.0
-              },
               "max_msgs_per_interval": {
                 "description": "New maximum messages per finality provider per interval (if provided)",
                 "type": [

contracts/finality/schema/raw/execute.json

@@ -266,24 +266,6 @@
         "update_config": {
           "type": "object",
           "properties": {
-            "bsn_activation_height": {
-              "description": "New BSN activation height (if provided)",
-              "type": [
-                "integer",
-                "null"
-              ],
-              "format": "uint64",
-              "minimum": 0.0
-            },
-            "finality_signature_interval": {
-              "description": "New finality signature interval (if provided)",
-              "type": [
-                "integer",
-                "null"
-              ],
-              "format": "uint64",
-              "minimum": 0.0
-            },
             "max_msgs_per_interval": {
               "description": "New maximum messages per finality provider per interval (if provided)",
               "type": [

contracts/finality/src/contract.rs

@@ -190,16 +190,12 @@ pub fn execute(
             min_pub_rand,
             max_msgs_per_interval,
             rate_limiting_interval,
-            bsn_activation_height,
-            finality_signature_interval,
         } => handle_update_config(
             deps,
             info,
             min_pub_rand,
             max_msgs_per_interval,
             rate_limiting_interval,
-            bsn_activation_height,
-            finality_signature_interval,
         ),
     }
 }
@@ -1099,8 +1095,6 @@ pub(crate) mod tests {
             min_pub_rand: Some(200),
             max_msgs_per_interval: None,
             rate_limiting_interval: None,
-            bsn_activation_height: None,
-            finality_signature_interval: None,
         };
         let admin_info = message_info(&admin, &[]);
         let res = execute(deps.as_mut(), mock_env(), admin_info.clone(), update_msg).unwrap();
@@ -1114,19 +1108,12 @@ pub(crate) mod tests {
         let config: Config = from_json(config_query).unwrap();
         assert_eq!(config.bsn_id, bsn_id); // unchanged
         assert_eq!(config.min_pub_rand, 200); // updated
-        assert_eq!(config.bsn_activation_height, bsn_activation_height); // unchanged
-        assert_eq!(
-            config.finality_signature_interval,
-            finality_signature_interval
-        ); // unchanged
 
         // Test 2: Update multiple fields at once
         let update_msg = ExecuteMsg::UpdateConfig {
             min_pub_rand: Some(300),
             max_msgs_per_interval: Some(150),
             rate_limiting_interval: Some(15000),
-            bsn_activation_height: Some(2000),
-            finality_signature_interval: Some(200),
         };
         let res = execute(deps.as_mut(), mock_env(), admin_info.clone(), update_msg).unwrap();
 
@@ -1141,17 +1128,13 @@ pub(crate) mod tests {
         assert_eq!(config.min_pub_rand, 300);
         assert_eq!(config.rate_limiting.max_msgs_per_interval, 150);
         assert_eq!(config.rate_limiting.block_interval, 15000);
-        assert_eq!(config.bsn_activation_height, 2000);
-        assert_eq!(config.finality_signature_interval, 200);
 
         // Test 3: Non-admin cannot update config
         let non_admin_info = message_info(&non_admin, &[]);
         let update_msg = ExecuteMsg::UpdateConfig {
             min_pub_rand: Some(999),
             max_msgs_per_interval: None,
             rate_limiting_interval: None,
-            bsn_activation_height: None,
-            finality_signature_interval: None,
         };
         let err = execute(deps.as_mut(), mock_env(), non_admin_info, update_msg).unwrap_err();
         assert_eq!(err, ContractError::Admin(AdminError::NotAdmin {}));
@@ -1161,8 +1144,6 @@ pub(crate) mod tests {
             min_pub_rand: None,
             max_msgs_per_interval: None,
             rate_limiting_interval: None,
-            bsn_activation_height: None,
-            finality_signature_interval: None,
         };
         let err = execute(deps.as_mut(), mock_env(), admin_info, empty_update_msg).unwrap_err();
         assert_eq!(err, ContractError::NoConfigFieldsToUpdate);
@@ -1195,8 +1176,6 @@ pub(crate) mod tests {
             min_pub_rand: Some(0), // invalid: must be > 0
             max_msgs_per_interval: None,
             rate_limiting_interval: None,
-            bsn_activation_height: None,
-            finality_signature_interval: None,
         };
         let err = execute(
             deps.as_mut(),
@@ -1212,8 +1191,6 @@ pub(crate) mod tests {
             min_pub_rand: None,
             max_msgs_per_interval: Some(0), // invalid: must be > 0
             rate_limiting_interval: None,
-            bsn_activation_height: None,
-            finality_signature_interval: None,
         };
         let err = execute(
             deps.as_mut(),
@@ -1229,8 +1206,6 @@ pub(crate) mod tests {
             min_pub_rand: None,
             max_msgs_per_interval: None,
             rate_limiting_interval: Some(0), // invalid: must be > 0
-            bsn_activation_height: None,
-            finality_signature_interval: None,
         };
         let err = execute(
             deps.as_mut(),
@@ -1240,23 +1215,6 @@ pub(crate) mod tests {
         )
         .unwrap_err();
         assert_eq!(err, ContractError::InvalidRateLimitingInterval(0));
-
-        // Test invalid finality_signature_interval
-        let invalid_finality_interval_update = ExecuteMsg::UpdateConfig {
-            min_pub_rand: None,
-            max_msgs_per_interval: None,
-            rate_limiting_interval: None,
-            bsn_activation_height: None,
-            finality_signature_interval: Some(0), // invalid: must be > 0
-        };
-        let err = execute(
-            deps.as_mut(),
-            mock_env(),
-            admin_info,
-            invalid_finality_interval_update,
-        )
-        .unwrap_err();
-        assert_eq!(err, ContractError::InvalidFinalitySignatureInterval(0));
     }
 
     #[test]

contracts/finality/src/exec/config.rs

@@ -4,8 +4,7 @@ use crate::error::ContractError;
 use crate::msg::BabylonMsg;
 use crate::state::config::{get_config, set_config, ADMIN};
 use crate::validation::{
-    validate_finality_signature_interval, validate_max_msgs_per_interval, validate_min_pub_rand,
-    validate_rate_limiting_interval,
+    validate_max_msgs_per_interval, validate_min_pub_rand, validate_rate_limiting_interval,
 };
 use babylon_bindings::BabylonQuery;
 
@@ -16,8 +15,6 @@ pub fn handle_update_config(
     min_pub_rand: Option<u64>,
     max_msgs_per_interval: Option<u32>,
     rate_limiting_interval: Option<u64>,
-    bsn_activation_height: Option<u64>,
-    finality_signature_interval: Option<u64>,
 ) -> Result<Response<BabylonMsg>, ContractError> {
     // Only admin can update config
     ADMIN.assert_admin(deps.as_ref(), &info.sender)?;
@@ -46,19 +43,6 @@ pub fn handle_update_config(
         has_updates = true;
     }
 
-    // Update bsn_activation_height if provided (no validation needed - any u64 is valid)
-    if let Some(new_activation_height) = bsn_activation_height {
-        config.bsn_activation_height = new_activation_height;
-        has_updates = true;
-    }
-
-    // Update finality_signature_interval if provided
-    if let Some(new_finality_interval) = finality_signature_interval {
-        validate_finality_signature_interval(new_finality_interval)?;
-        config.finality_signature_interval = new_finality_interval;
-        has_updates = true;
-    }
-
     // Check if any fields were actually updated
     if !has_updates {
         return Err(ContractError::NoConfigFieldsToUpdate);

contracts/finality/src/msg.rs

@@ -232,10 +232,6 @@ pub enum ExecuteMsg {
         max_msgs_per_interval: Option<u32>,
         /// New rate limiting interval in blocks (if provided)
         rate_limiting_interval: Option<u64>,
-        /// New BSN activation height (if provided)
-        bsn_activation_height: Option<u64>,
-        /// New finality signature interval (if provided)
-        finality_signature_interval: Option<u64>,
     },
 }
 

docs/SPEC.md

@@ -852,8 +852,6 @@ UpdateConfig {
     min_pub_rand: Option<u64>,
     max_msgs_per_interval: Option<u32>,
     rate_limiting_interval: Option<u64>,
-    bsn_activation_height: Option<u64>,
-    finality_signature_interval: Option<u64>,
 }
 ```
 
@@ -869,7 +867,6 @@ handler with the following verification logic:
    - If `min_pub_rand` is provided, ensure it is ≥ 1
    - If `max_msgs_per_interval` is provided, ensure it is ≥ 1
    - If `rate_limiting_interval` is provided, ensure it is ≥ 1
-   - If `finality_signature_interval` is provided, ensure it is ≥ 1
    - Use the same validation functions as during contract instantiation
 
 3. **Storage Operations**: Update the contract configuration:
@@ -879,6 +876,9 @@ handler with the following verification logic:
    - Save the updated configuration to storage
    - Return success response
 
+> **Note**: The `bsn_activation_height` and `finality_signature_interval` parameters are 
+> immutable and cannot be updated after contract instantiation
+
 **Usage Context:** This message allows the admin to modify operational
 parameters without requiring contract migration, enabling fine-tuning of rate
 limits, finality intervals, and other settings based on network conditions.

docs/contract-managment.md

@@ -171,15 +171,15 @@ underscores with a maximum length of 100 characters.
 **min_pub_rand**  
 > **Type**: Integer (positive)  
 > **Required**: Yes  
-> **Mutable**: No  
+> **Mutable**: Yes (via `update_config` message)  
 
 The `min_pub_rand` parameter sets the minimum number of public randomness values that
 finality providers must include in each public randomness commitment.
 
 **rate_limiting_interval**  
 > **Type**: Integer (positive)  
 > **Required**: Yes  
-> **Mutable**: No  
+> **Mutable**: Yes (via `update_config` message)  
 
 The `rate_limiting_interval` specifies the length (in Babylon Genesis blocks) of the rate limiting window.
 Within each interval, a finality provider can submit a limited number of messages,
@@ -191,7 +191,7 @@ how often a provider can interact with the contract.
 **max_msgs_per_interval**  
 > **Type**: Integer (positive)  
 > **Required**: Yes  
-> **Mutable**: No  
+> **Mutable**: Yes (via `update_config` message)  
 
 The `max_msgs_per_interval` sets the maximum number of messages a finality provider
 can submit during each rate limiting interval.
@@ -341,6 +341,26 @@ JSON_MSG={
 > **Variable:**  
 > `$FP_BTC_PUBKEY`: Hex-encoded compressed BTC public key of the Finality Provider
 
+**Update Configuration Parameters**
+
+```shell
+JSON_MSG={
+  "update_config": {
+    "min_pub_rand": $MIN_PUB_RAND,
+    "max_msgs_per_interval": $MAX_MSGS_PER_INTERVAL,
+    "rate_limiting_interval": $RATE_LIMITING_INTERVAL
+  }
+}
+```
+> **Variables:**  
+> `$MIN_PUB_RAND`: (Optional) New minimum number of public randomness values required  
+> `$MAX_MSGS_PER_INTERVAL`: (Optional) New maximum messages per finality provider per interval  
+> `$RATE_LIMITING_INTERVAL`: (Optional) New rate limiting interval in blocks  
+
+> **Note**: All fields are optional - only provided fields will be updated. At least one field must be provided.
+> The `bsn_activation_height` and `finality_signature_interval` parameters are immutable 
+> and can only be set during instantiation.
+
 For details on when and why to use these messages, see [Contract Maintenance](#6-contract-maintenance).
 
 ## 5. Rollup BSN Registration