This repository was archived by the owner on Sep 8, 2025. It is now read-only.
feat: implement setting menu #1265
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy-babylonlabs
requested review from
0xDazzer,
jonybur,
jrwbabylonlab and
gbarkhatov
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR implements a comprehensive settings menu feature with theme selection, bug reporting, and additional menu options. The implementation replaces a simple theme toggle with a full-featured settings interface.
Key changes:
- Implements a new settings menu with theme selector, bug reporting, and policy links
- Adds new icon components for theme selection and bug reporting
- Updates the core UI library dependency to support the new menu components
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ui/common/components/Wallet/Connect.tsx | Adds onClose prop to SettingMenuContent components |
| src/ui/common/components/Menu/SettingMenu/index.ts | Exports new SettingMenuThemeSelector component |
| src/ui/common/components/Menu/SettingMenu/components/SettingMenuThemeSelector.tsx | New theme selector component with light/dark/system options |
| src/ui/common/components/Menu/SettingMenu/components/SettingMenuContent.tsx | Complete rewrite to implement full settings menu with multiple sections |
| src/ui/common/components/Icons/index.ts | Updates icon exports to use wildcard exports and adds new icons |
| src/ui/common/components/Icons/common/ThemeIcon.tsx | New theme icon component |
| src/ui/common/components/Icons/common/ReportBugIcon.tsx | New bug report icon component |
| src/ui/common/components/Icons/common/ChevronLeftIcon.tsx | New chevron left icon component |
| package.json | Updates core-ui library from 1.4.2 to 1.5.0 |
| interface SettingMenuContentProps { | ||
| className?: string; | ||
| onClose?: () => void; | ||
| } | ||
|
|
||
| export const SettingMenuContent = ({ className }: SettingMenuContentProps) => { |
There was a problem hiding this comment.
The onClose prop is defined in the interface but not destructured in the function parameter. Either remove it from the interface or use it in the component.
Suggested change
| export const SettingMenuContent = ({ className }: SettingMenuContentProps) => { | |
| export const SettingMenuContent = ({ className, onClose }: SettingMenuContentProps) => { |
Copilot uses AI. Check for mistakes.
| <SettingMenu.Spacer /> | ||
| <SettingMenu.CustomContent className="my-4 flex justify-center"> | ||
| <Button | ||
| className="!bg-[#D5FCE8] !text-black" |
There was a problem hiding this comment.
Hard-coded color values with important flags should be replaced with theme variables or CSS classes to maintain consistency with the design system.
Suggested change
| className="!bg-[#D5FCE8] !text-black" | |
| className="bg-baby-staking text-baby-staking-text" |
Copilot uses AI. Check for mistakes.
jeremy-babylonlabs
force-pushed
the
feat/implement-setting-menu
branch
from
fe3d623 to
90407a0
Compare
jeremy-babylonlabs
force-pushed
the
feat/implement-setting-menu
branch
from
90407a0 to
93b17ca
Compare
jeremy-babylonlabs
force-pushed
the
feat/implement-setting-menu
branch
from
93b17ca to
04ac10e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked by babylonlabs-io/core-ui#140