Skip to content

fixes #55: not working with theme debug enabled #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 1.x-1.x
Choose a base branch
from
Open

fixes #55: not working with theme debug enabled #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions js/flag.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,24 +21,28 @@ Backdrop.flagLink = function(context) {
* The new link.
*/
function updateLink(element, newHtml) {
var $newLink = $(newHtml);
var $tempContainer = $('<div>').html(newHtml); // Wrap in a container
var $newLink = $tempContainer.find('.flag-wrapper').first(); // Extract the actual wrapper

// Initially hide the message so we can fade it in.
$('.flag-message', $newLink).css('display', 'none');

// Reattach the behavior to the new <A> element. This element
// is either whithin the wrapper or it is the outer element itself.
// Reattach the behavior to the new <A> element.
var $nucleus = $newLink.is('a') ? $newLink : $('a.flag', $newLink);
$nucleus.addClass('flag-processed').click(flagClick);

// Find the wrapper of the old link.
var $wrapper = $(element).parents('.flag-wrapper:first');

// Replace the old link with the new one.
$wrapper.after($newLink).remove();
Backdrop.attachBehaviors($newLink.get(0));

$('.flag-message', $newLink).fadeIn();
setTimeout(function(){ $('.flag-message.flag-auto-remove', $newLink).fadeOut() }, 3000);
setTimeout(function () {
$('.flag-message.flag-auto-remove', $newLink).fadeOut()
}, 3000);

return $newLink.get(0);
}

Expand Down