Skip to content

Conversation

@futaz
Copy link

@futaz futaz commented Oct 17, 2016

…isible on it

Without this improvement, users can only edit task priority on taskboard when it is already differs from the default priority or when "Show task priority on taskboard" setting is enabled (so all tasks shows priority property even when it is the default one).

With this imporvement, users can edit priority even when it is the default one and the "Show task priority on taskboard" setting is disabled. After changing a default priority to something else, it will appear on the task' box of course and disappear when set back to the default.

Copy link

@Imran-imtiaz48 Imran-imtiaz48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The selected line conditionally renders the "remaining_hours" field as an editable div, displaying the task's remaining hours only if the current user has the :update_remaining_hours permission for the project. This ensures that only authorized users can view and edit the remaining hours directly from the task view, enhancing security and role-based UI control. The approach is clear and consistent with permission-based rendering patterns, promoting maintainability and a better user experience by hiding editing options from those without the necessary privileges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants