feat: add file-scoped comments to /plannotator-review#303
Merged
backnotprop merged 2 commits intobacknotprop:mainfrom Mar 15, 2026
Merged
feat: add file-scoped comments to /plannotator-review#303backnotprop merged 2 commits intobacknotprop:mainfrom
backnotprop merged 2 commits intobacknotprop:mainfrom
Conversation
Owner
|
Ah, nice work. I was just giving this a shot! Alright, I'll get it in review. |
Contributor
Author
|
feel free to dismiss if you have some other implementation in mind |
Owner
|
No, all good. We can make this work. |
Replace the custom popover implementation in FileHeader (~88 lines of hand-rolled state, click-outside, and escape handling) with the existing CommentPopover component from packages/ui. This gives us expand-to-dialog mode, image attachments, scroll-aware positioning, and keyboard shortcuts for free, while saving ~62 net lines. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
|
Nice work on this — the I pushed a small refactor (cf77b73) to swap the custom popover in What changed:
What you get for free by reusing it:
Everything else from your PR (scope field, export format, ReviewPanel sorting) is kept as-is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/plannotator-reviewvia aFile Commentcomposer in each file header.### File Comment).Closes #302
Test plan
bun run build:review/plannotator-review(feedback payload included### File Comment).