-
Notifications
You must be signed in to change notification settings - Fork 98
feat(backstage): Add Gateway API HTTPRoute support as Ingress successor #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Gateway API is the successor to Ingress and is now the recommended approach for HTTP routing in Kubernetes. The Ingress API spec has been frozen and will not receive new features, while Gateway API is actively developed with richer routing capabilities and better role separation. - Add httproute.yaml template - Add httpRoute configuration in values.yaml - Add ci/httproute-values.yaml for testing - Bump chart minor version Signed-off-by: younsl <[email protected]>
Signed-off-by: younsl <[email protected]>
Signed-off-by: younsl <[email protected]>
03036ff to
8806b90
Compare
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
|
Gentle ping @vinzscam |
|
Not stale |
vinzscam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I've added a bunch of comments regarding parentRefs which at the moment is hardcoded to a single value. Have a look!
|
Thanks for the detailed review! I agree parentRefs should support multiple values. I'll update it to accept a list so users can attach the route to multiple Gateways. Will push the changes shortly. |
Support multiple Gateway references by converting parentRefs to a list. Add validation that fails helm rendering when httpRoute.enabled is true but parentRefs is empty, preventing misconfigured HTTPRoute deployment. Resolves review comments by @vinzscam: - backstage#308 (comment) - backstage#308 (comment) - backstage#308 (comment) - backstage#308 (comment) Signed-off-by: younsl <[email protected]>
|
Note Heads up for reviewers: CI chart testing is expected to fail on this PR because # Install Gateway API CRDs
kubectl apply -f https://github.com/kubernetes-sigs/gateway-api/releases/download/v1.2.1/standard-install.yaml |
Signed-off-by: younsl <[email protected]>
|
@vinzscam PTAL |
Description of the change
Add HTTPRoute resource template and values configuration for Gateway API as an alternative to traditional Ingress.
Gateway API is the successor to Ingress and is now the recommended approach for HTTP routing in Kubernetes. The Ingress API spec has been frozen and will not receive new features, while Gateway API is actively developed with richer routing capabilities and better role separation.
Changes
Existing or Associated Issue(s)
None
Additional Information
Example usage
This configuration creates an HTTPRoute that attaches to a Gateway named my-gateway and routes traffic for backstage.example.com to the Backstage service.
References
Checklist
Chart.yamlaccording to semver.values.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.