-
-
Notifications
You must be signed in to change notification settings - Fork 1
Cleanup #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Outdated Config Causes Application Failure
The config references Backstage\Translations\Filament\Resources\TranslationResource::class but the backstage/translations dependency was removed from packages/core/composer.json. This will cause a class not found error when the application tries to load this resource. The resource should be commented out like the plugin on line 10.
packages/core/config/backstage/cms.php#L29-L30
cms/packages/core/config/backstage/cms.php
Lines 29 to 30 in 6a5cd57
| Backstage\Translations\Filament\Resources\TranslationResource::class, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Translation Resource: Ghost in the Machine
The TranslationResource class remains active in the resources array while the backstage/translations dependency was removed from composer.json and the TranslationsPlugin was commented out. This creates an inconsistency that will cause a class-not-found error at runtime when the application attempts to load this resource.
packages/core/config/backstage/cms.php#L29-L30
cms/packages/core/config/backstage/cms.php
Lines 29 to 30 in c4cad94
| Backstage\Translations\Filament\Resources\TranslationResource::class, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Pest Monorepo: Inconsistent Versioning
The root composer.json specifies pestphp/pest version ^3.7 and related plugins at ^3.0, while all package composer.json files (packages/core, packages/media, packages/redirects) specify ^4.0 or ^4.1. This version mismatch in a monorepo can cause dependency resolution conflicts and inconsistent testing environments.
composer.json#L58-L61
Lines 58 to 61 in e5bdc9e
| "orchestra/testbench": "^9.0", | |
| "pestphp/pest": "^3.7", | |
| "pestphp/pest-plugin-arch": "^3.0", | |
| "pestphp/pest-plugin-laravel": "^3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Orphaned Class Reference Breaks Config
The TranslationResource class is still referenced in the resources array, but the backstage/translations dependency was removed from composer.json. This will cause a class not found error when the config is loaded since the package providing this class is no longer installed.
packages/core/config/backstage/cms.php#L29-L30
cms/packages/core/config/backstage/cms.php
Lines 29 to 30 in 7dc2a39
| Backstage\Translations\Filament\Resources\TranslationResource::class, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Orphaned Config: Missing Translation Dependency
The config references Backstage\Translations\Filament\Resources\TranslationResource::class but the backstage/translations dependency was removed from composer.json. This causes a class not found error when the application attempts to load this resource.
packages/core/config/backstage/cms.php#L29-L30
cms/packages/core/config/backstage/cms.php
Lines 29 to 30 in 307a3fd
| Backstage\Translations\Filament\Resources\TranslationResource::class, |
39dcba0 Fix styling d9f820f Pest plugin upgrade 8004dc1 Fix styling aee3c04 PHP 8.3 0b2f1f3 Fix styling 075db20 Fix duplicated save for content 870ef5b Fix styling 97ecb49 feat: use cdn url modifiers in uploadcare (#13) 3159ee0 Fix styling b86316a order by values in db dd793f7 Fix styling febf476 Use fields ^1 e436a8f Fix styling 5f71462 url not changed when original was not public c8a9f4b Fix styling f0bed43 Remove duplicated actions 0bee051 Fix styling ef719a5 Merge pull request #10 from backstagephp/version-tree-fixes 73c173e Fix styling 0c94d5f Merge pull request #9 from backstagephp/fix/laravel-translations-push-mistake git-subtree-dir: packages/laravel-translations git-subtree-split: 39dcba09ab18373289b413973e24fbacd0a4ba38
95464a3 build(deps): bump actions/checkout from 5 to 6 (#48) 071cc0f Use php 8.3, Laravel 12.x 0f69bbd Pest plugin upgrade e6c2693 PHP 8.3 21498fa Merge pull request #10 from backstagephp/version-tree-fixes 374b06e On push for tag git-subtree-dir: packages/fields git-subtree-split: 95464a3a009bce106886185afadd53a89586804c
Versions, composer fixes, etc.
Note
Upgrades to PHP 8.3 across CI and packages, migrates Redirects to Filament v4 schema/actions, replaces external translations language model with an internal one, updates Composer setup, and removes obsolete configs.
8.3(.github/workflows/*), drop--devin installs, and adjust Laravel setup to clonecmsand use path repos.^8.3across root and packages; bump dev tools (Pest, Pint, Collision, PHPStan); switch Backstage deps toself.version; add path repopackages/*.Backstage\Models\Language(custom Eloquent model,default(),scopeActive()), andBackstage\Resources\LanguageResource(not tenant-scoped).packages/core/config/backstage/cms.phpto useBackstage\Media\MediaPluginand comment translations plugin.packages/core/src/helpers.php.config/backstage/{cms.php,media.php,translations.php}.RedirectResourceto useFilament\Schemas\Schema/Tabs, newrecordActions/toolbarActions, and typed$navigationIcon.ListRedirects,EditRedirect) to new action classes (Action,CreateAction,ImportAction,DeleteAction) andSizeenum.announcements,fields,media,redirects,laravel-redirects,laravel-translations,uploadcare-fieldto PHP^8.3, adjust deps, and wrap translation helpers withfunction_existsguards.Written by Cursor Bugbot for commit 66d6a8a. This will update automatically on new commits. Configure here.