Skip to content

fix: reordering bug with drag n drop in repeater #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Baspa merged 1 commit into from
Nov 5, 2025
Merged

fix: reordering bug with drag n drop in repeater #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions src/Fields/Repeater.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,14 @@ public static function make(string $name, ?Field $field = null): Input
{
$input = self::applyDefaultSettings(Input::make($name), $field);

$isReorderable = $field->config['reorderable'] ?? self::getDefaultConfig()['reorderable'];
$isReorderableWithButtons = $field->config['reorderableWithButtons'] ?? self::getDefaultConfig()['reorderableWithButtons'];

$input = $input->label($field->name ?? self::getDefaultConfig()['label'] ?? null)
->addActionLabel($field->config['addActionLabel'] ?? self::getDefaultConfig()['addActionLabel'])
->addable($field->config['addable'] ?? self::getDefaultConfig()['addable'])
->deletable($field->config['deletable'] ?? self::getDefaultConfig()['deletable'])
->reorderable($field->config['reorderable'] ?? self::getDefaultConfig()['reorderable'])
->reorderable($isReorderable)
->collapsible($field->config['collapsible'] ?? self::getDefaultConfig()['collapsible'])
->cloneable($field->config['cloneable'] ?? self::getDefaultConfig()['cloneable'])
->columns($field->config['columns'] ?? self::getDefaultConfig()['columns']);
Expand All @@ -72,10 +75,34 @@ public static function make(string $name, ?Field $field = null): Input
$input = $input->compact();
}

if ($field->config['reorderableWithButtons'] ?? self::getDefaultConfig()['reorderableWithButtons']) {
if ($isReorderableWithButtons) {
$input = $input->reorderableWithButtons();
}

// Fix for Filament Forms v4.2.0 reorder bug
// The default reorder action has a bug where array_flip() creates integer values
// that get merged with the state array, causing type errors
if ($isReorderable || $isReorderableWithButtons) {
$input = $input->reorderAction(function ($action) {
return $action->action(function (array $arguments, Input $component): void {
$currentState = $component->getRawState();
$newOrder = $arguments['items'];

// Reorder the items based on the new order
$reorderedItems = [];
foreach ($newOrder as $oldIndex) {
if (isset($currentState[$oldIndex])) {
$reorderedItems[] = $currentState[$oldIndex];
}
}

$component->rawState($reorderedItems);
$component->callAfterStateUpdated();
$component->shouldPartiallyRenderAfterActionsCalled() ? $component->partiallyRender() : null;
});
});
}

if ($field && ! $field->relationLoaded('children')) {
$field->load('children');
}
Expand Down