Skip to content

Fix unit tests on Windows. #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix unit tests on Windows. #1291

wants to merge 1 commit into from

Conversation

@asashour
Copy link

This change modifies the path of Windows in order to match the expectations.

@badeball
Copy link
Owner

badeball commented Jun 9, 2025

If this is to be fixed, then it also needs to run in CI (currently only integration tests are run on Windows). Can you verify that all tests run on Windows in CI? IE. change and run the workflows in your fork.

badeball added a commit that referenced this pull request Oct 25, 2025
@badeball
Run whole test suite on Windows
39b7c87 
This is possible now that posix path is used internally. This patch
supersedes and closes #1291 [1].

[1] #1291
badeball added a commit that referenced this pull request Oct 25, 2025
@badeball
Run whole test suite on Windows
dc4475c 
.. aside from prettier, which I for unknown reasons can't configure to
use lf line endings on Windows. This is possible now that posix path is
used internally. This patch supersedes and closes #1291 [1].

[1] #1291
badeball added a commit that referenced this pull request Oct 25, 2025
@badeball
Run unit tests on Windows
dfe499d 
This is possible now that posix path is used internally. This patch
supersedes and closes #1291 [1].

[1] #1291
badeball added a commit that referenced this pull request Oct 26, 2025
@badeball
Run unit tests on Windows
6f1b626 
This patch supersedes and closes #1291 [1].

[1] #1291
badeball added a commit that referenced this pull request Oct 26, 2025
@badeball
Run unit tests on Windows
d8cbfcc 
This patch supersedes and closes #1291 [1].

[1] #1291
badeball added a commit that referenced this pull request Oct 26, 2025
@badeball
Run unit tests on Windows
18e5254 
This patch supersedes and closes #1291 [1].

[1] #1291
@badeball badeball closed this in 790fc96 Oct 26, 2025
@badeball
Copy link
Owner

@asashour, I've fixed this with 790fc96.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asashour @badeball