This repository was archived by the owner on Jan 9, 2025. It is now read-only.
Added Image upload functionality for configurable product variants#84
Open
akhtarkhan1 wants to merge 15 commits intobagisto:v1.3.3from
Open
Added Image upload functionality for configurable product variants#84akhtarkhan1 wants to merge 15 commits intobagisto:v1.3.3from
akhtarkhan1 wants to merge 15 commits intobagisto:v1.3.3from
Conversation
Compatible with bagisto v1.3.3
fixed issues in downloadable files
Issue was in uploading image zip file
Implemented the bulk upload functionality for multilingual product
ghermans
reviewed
Aug 8, 2022
| $imagePath = storage_path('app/public/ imported-products/extracted-images/admin/'. $dataFlowProfileRecord->id); | ||
|
|
||
| if (!file_exists($imagePath)) { | ||
| mkdir($imagePath, 0777, true); |
Contributor
There was a problem hiding this comment.
Why don't you use Storage::makeDirectory($imagePath);?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Image upload functionality for configurable product variants