Open
Conversation
Author
|
@eldomagan Hi, let me know if this is good |
Contributor
|
Hi @Alex92zz, thanks for your contribution. Sorry for the late reply, I was on holiday. I’ll check it out soon. |
eldomagan
requested changes
Sep 3, 2025
Contributor
eldomagan
left a comment
eldomagan
left a comment
There was a problem hiding this comment.
Thanks for this contribution! I've tested the PR and have several feedback points:
Issues that need fixing:
- The feature doesn't work in its current state - could you test this locally first?
- The Livewire component needs to be registered in the theme's ServiceProvider
- There are multiple
</form>closing tags that break the layout
Enhancements to consider:
- We should add a setting to allow users to enable/disable suggestions directly from the theme editor
- I think it would be better to convert the entire
search-formblade component to a Livewire component
Would you be able to address these points? Happy to provide more specific guidance on any of them. The core idea is solid, just needs some refinement!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix search suggestion for NewTheme