Support caching queries with autodiscovered types #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+91
to
+94
| if (cached && key.ResultTransformer?.AutoDiscoverTypes == true && key.ResultTransformer.AutoDiscoveredAliases != null) | ||
| { | ||
| Cache.Put(new QueryAliasesKey(key), key.ResultTransformer.AutoDiscoveredAliases); | ||
| } |
There was a problem hiding this comment.
In case we need aliases, this adds them to the cache for allowing retrieving them.
I though about using a local concurrent dictionary, but that would not work with distributed caches. We need theses aliases to be in distributed caches too.
There was a problem hiding this comment.
By the way, this works only for non-obsoleted Get. So, the bug would remain for users having an obsolete custom query cache implementation. I think this is acceptable.
|
I have not regenerate async, so the async code is still failing. That is the only failure I have seen in the build I have looked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix nhibernate#3169
targeting nhibernate#3172