Add a flag to use the old C++ ABI when compiled with newer GCC.#73
Open
bdaskalov wants to merge 1 commit intobaidu-research:masterfrom
Open
Add a flag to use the old C++ ABI when compiled with newer GCC.#73bdaskalov wants to merge 1 commit intobaidu-research:masterfrom
bdaskalov wants to merge 1 commit intobaidu-research:masterfrom
Conversation
Author
|
@jaredcasper Can you please take a look? |
Contributor
|
Looks okay to me, only suggestion may be to only add the flag if g++ version 5+ is being used. However, I no longer have write access to this repo (I don't work at Baidu anymore). |
Author
|
@jaredcasper Do you know somebody who could be able to review and merge it? |
|
Hello, I can confirm this works on Ubuntu 16.04 and fixes the issue raised in #59. Is anybody able to merge this fix so we can install from official master? |
|
I used this PR to build with gcc-5 on Ubuntu 17.04 and Cuda 8. The following is the errors I received: and the list of errors goes on all with the same description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a compile flag which specifies that newer GCC version should use the old ABI when compiling the Tensorflow extension.