split by ChenChen1113 · Pull Request #2 · baishancloud/lua-consistent-hash

ChenChen1113 · 2017-07-27T08:22:15Z

split lch_new.

drmingdrmer · 2017-08-26T02:31:42Z

consistenthash.c


 static int
-node_cmp( const hashnode_t *a, const hashnode_t *b )
+node_cmp( const hashnode_t *a, const hashnode_t *b )	/*for qsort below, sort from small to large*/


注释一般都单起1行.不要放在代码中间.

drmingdrmer · 2017-08-26T02:32:12Z

consistenthash.c



-    while ( s + 1 < e ) {
+    while ( s + 1 < e ) {	/*binary search*/


你的vim里有NERD-Comment这个插件. ctrl-f切换注释.

drmingdrmer · 2017-08-26T02:32:37Z

consistenthash.c



-    p = get_continuum( L, 1 );
+    p = get_continuum( L, 1 );    /*get the storage address for userdata*/


不是很关键的注释自己看就好了..不用提交上来.

drmingdrmer · 2017-08-26T02:32:52Z

consistenthash.c

    if ( lua_isnumber( L, 3 ) ) {
        n_replica = lua_tointeger( L, 3 );
-        if ( n_replica > MAX_REPLICA ) {
+	if ( n_replica > MAX_REPLICA ) {	/*the number of replica nodes is limited to MAX_REPLICA*/


类似这种注释没啥用处..

drmingdrmer · 2017-08-26T08:33:19Z

consistenthash.c

 #include <lua.h>
 #include <lauxlib.h>

+#include"md5.h"


注意空格

装个astyle, 专门用来格式化c代码的.

这里是配置文件, 放到 ~/.astylerc

#Bracket style style=google #Tab #使用2个空格作为一个缩进单位 indent=spaces=4 #Indentation #缩进case本身 indent-switches #缩进case内容 indent-cases #缩进宏定义内容 # indent-preproc-block # indent-preproc-cond # indent-preproc-define #缩进注释 indent-col1-comments #Padding #操作符两端补空格 pad-oper #if/for/while后面与小括号之间补空格 pad-header #除上述两点外，都不补空格 unpad-paren #声明指针时，*贴紧变量名 align-pointer=name #Formatting #单行的分支循环块补充花括号 add-brackets #凡是tab都替换成两个空格 convert-tabs #单行最长100个字节 max-code-length=100 #单行长度超过100字节时根据条件逻辑进行切分换行 break-after-logical #c/c++风格 mode=c #保持一行代码的写法 keep-one-line-blocks #Other #转化后的文件修改时间不变 preserve-date #linux风格的换行符 lineend=linux #show detail verbose # do not create backup suffix=none

drmingdrmer · 2017-08-26T08:34:02Z

md5.h

@@ -0,0 +1,15 @@
+typedef struct {


.h头文件要加重复include的判断.

drmingdrmer · 2017-08-26T09:46:06Z

consistenthash.c


    while ( s + 1 < e ) {
-        mid = ( s+e ) / 2;
+        mid = ( s+e ) ;


drmingdrmer · 2017-08-26T09:46:28Z

consistenthash.c

    if ( lua_isnumber( L, 3 ) ) {
        n_replica = lua_tointeger( L, 3 );
-        if ( n_replica > MAX_REPLICA ) {
+	if ( n_replica > MAX_REPLICA ) {


注意tab和space.都用space

drmingdrmer · 2017-08-26T09:46:42Z

consistenthash.c


    while ( n_names < n_replica ) {

+        /* assignment */


这个注释有啥用啊..

drmingdrmer · 2017-08-26T09:46:48Z

consistenthash.c


    if ( 0 == n ) {
-        luaL_argerror( L, 2, "Empty table" );
+    	luaL_argerror( L, 2, "Empty table" );


drmingdrmer · 2017-08-26T09:47:05Z

consistenthash.c

    for ( i = 0; i < conti->n_buckets; i++ ) {
        i_nodes = point_search( conti, step * i );
-        conti->buckets[ i ] = i_nodes;
+        conti->buckets[ i ] = i_nodes;    /*map the node to a bucket*/


尽量不用尾注释

drmingdrmer · 2017-08-27T12:17:42Z

测试跑过了没~

drmingdrmer · 2017-10-16T07:04:39Z

md5.h

@@ -0,0 +1,19 @@
+#ifndef MD5_H
+#define MD5_H
+#endif


看看c preprocessor的例子和教程.这个endif加的不对

drmingdrmer · 2017-10-16T07:06:05Z

Makefile


 LUAPKG = lua5.2
-CFLAGS = `pkg-config $(LUAPKG) --cflags` -fPIC -O3 -Wall $(OMIT_FRAME_PTR)
+CFLAGS = `pkg-config $(LUAPKG) --cflags` -fPIC -O3 -Wall $(OMIT_FRAME_PTR) -I/usr/local/include/luajit-2.1


这个地方不能直接用带版本的绝对路径..不是所有的机器上都装的2.1

add_comment

e180386

ChenChen1113 force-pushed the master branch from 6f4bf60 to 1c5dfe1 Compare July 28, 2017 02:00

ChenChen1113 force-pushed the master branch from 1c5dfe1 to ec58f4c Compare August 25, 2017 01:51

drmingdrmer requested changes Aug 26, 2017

View reviewed changes

drmingdrmer requested changes Oct 16, 2017

View reviewed changes

compile with luajit

6eb004a

ChenChen1113 force-pushed the master branch from 18f962e to 6eb004a Compare October 18, 2017 08:16



		while ( s + 1 < e ) {
		while ( s + 1 < e ) { /binary search/



		p = get_continuum( L, 1 );
		p = get_continuum( L, 1 ); /get the storage address for userdata/

Comments

Conversation

ChenChen1113 commented Jul 27, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

drmingdrmer commented Aug 27, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants