Merged
Conversation
bakaq
requested changes
Oct 21, 2025
Owner
There was a problem hiding this comment.
Looks good. I've pointed out some places that can improve in terms of purity. Validation of the manifest is something that could certainly be done in just pure and monotonic Prolog, though it's certainly very annoying without something like Qupak.
I also really like the enforcement of licenses.
bakaq
reviewed
Oct 22, 2025
triska
reviewed
Oct 23, 2025
bakaq
requested changes
Oct 23, 2025
Co-authored-by: Kauê Hunnicutt Bazilli <bakaq@bakaq.net>
Co-authored-by: Kauê Hunnicutt Bazilli <bakaq@bakaq.net>
bakaq
approved these changes
Oct 24, 2025
Owner
bakaq
left a comment
There was a problem hiding this comment.
Looks good to me. Let's get this in!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature: Manifest Validation
This PR introduces manifest validation that runs before package installation. Additionally, all packages are now required to specify a license.
Changes
Future Work
--validate-only)closes #23