Skip to content

Fix alter table add key exception #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
Merged

Fix alter table add key exception #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mysql_ch_replicator/converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,13 +582,13 @@ def convert_alter_query(self, mysql_query, db_name):
tokens = tokens[1:]

if op_name == 'add':
if tokens[0].lower() in ('constraint', 'index', 'foreign', 'unique'):
if tokens[0].lower() in ('constraint', 'index', 'foreign', 'unique', 'key'):
continue
self.__convert_alter_table_add_column(db_name, table_name, tokens)
continue

if op_name == 'drop':
if tokens[0].lower() in ('constraint', 'index', 'foreign', 'unique'):
if tokens[0].lower() in ('constraint', 'index', 'foreign', 'unique', 'key'):
continue
self.__convert_alter_table_drop_column(db_name, table_name, tokens)
continue
Expand Down
11 changes: 11 additions & 0 deletions test_mysql_ch_replicator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1420,6 +1420,17 @@ def test_add_column_first_after_and_drop_column(monkeypatch):
assert_wait(lambda: ch.select(TEST_TABLE_NAME, where="id=44")[0]['c1'] == 111)
assert_wait(lambda: ch.select(TEST_TABLE_NAME, where="id=44")[0]['c2'] == 222)

# Test add KEY
mysql.execute(
f"ALTER TABLE `{TEST_TABLE_NAME}` ADD KEY `idx_c1_c2` (`c1`,`c2`)")
mysql.execute(
f"INSERT INTO `{TEST_TABLE_NAME}` (id, c1, c2) VALUES (46, 333, 444)",
commit=True,
)
assert_wait(lambda: len(ch.select(TEST_TABLE_NAME, where="id=46")) == 1)
assert_wait(lambda: ch.select(TEST_TABLE_NAME, where="id=46")[0]['c1'] == 333)
assert_wait(lambda: ch.select(TEST_TABLE_NAME, where="id=46")[0]['c2'] == 444)

# Test drop column
mysql.execute(
f"ALTER TABLE `{TEST_TABLE_NAME}` DROP COLUMN c2")
Expand Down