Skip to content

Node separation PR tweaks#12

Merged
joaobrunoah merged 8 commits intoseparate-swapper-from-senderfrom
node-separation-tweaks
Oct 10, 2025
Merged

Node separation PR tweaks#12
joaobrunoah merged 8 commits intoseparate-swapper-from-senderfrom
node-separation-tweaks

Conversation

@EndymionJkb
Copy link
Contributor

Description

There were a lot of difficult-to-describe suggestions, so I just made this follow-on. You can see the changes commit-by-commit, but essentially:

  1. Ignore .wake files in .gitignore
  2. Replace hard-code number with constant
  3. Rename HookAngstrom to AngstromHook (should probably have "Hook" at the end)
  4. Adding some docs (plus the usual style things)
  5. Factor out common code in hooks
  6. Factor out assembly code to minimize the number of assembly blocks

There shouldn't be any semantic changes.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Optimization: [ ] gas / [ ] bytecode
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

Issue Resolution

Copy link
Collaborator

@joaobrunoah joaobrunoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense @EndymionJkb ! Thanks!

@joaobrunoah joaobrunoah merged commit 73de390 into separate-swapper-from-sender Oct 10, 2025
3 checks passed
@joaobrunoah joaobrunoah deleted the node-separation-tweaks branch October 10, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants