Merged
Conversation
10 tasks
EndymionJkb
approved these changes
Sep 16, 2025
Contributor
EndymionJkb
left a comment
EndymionJkb
left a comment
There was a problem hiding this comment.
LGTM! Matches the others.
joaobrunoah
added a commit
that referenced
this pull request
Sep 19, 2025
* Fix names of files and implement swap tests * Create hook logic and tests to verify signatures * Fix signature test * Test error OnlyOncePerBlock * 100% coverage * Block unbalanced liquidity operations when Angstrom is locked * 100% test coverage * Commit test * Run github action * Remove unused dependency * Natspec * Fix solady install * Fix lint * Fix function mutability * Modify package.json to Angstrom * Readme * Fix contract names and repo * docs: update comments and non-semantics * refactor: rename `_nodes` for clarity * refactor: add `isRegisteredNode` getter; add `fromValidator` modifier on direct swaps * refactor: add onlyWhenLocked modifier, and isolate updates in `_unlockAngstrom` * refactor: rename validator modifier; simplify unlockAngstrom helper * refactor: simplify/rename unlock functions; move getters from mock; reorder functions * test: don't need leading underscores in tests * test: introduce intermediate test * fix: createHook in proper place * test: propagate intermediate test * refactor: rename validator modifier; simplify onBeforeSwap * refactor: remove redundant code * refactor: rename/reorder * refactor: remove unused function * refactor: one more simplification - only revert in one place for each error. * docs: adjust comments after review * Merge pull request #7 from balancer/support-hardhat-contracts Test with hardhat * Fix PR comment * Add event when adding/removing node * Use OwnableAuthentication instead of Singleton * Use mcopy instead of a for loop * Update contracts/AngstromBalancer.sol Co-authored-by: Juan Ignacio Ubeira <juani@balancerlabs.dev> * Unify invalid signature errors * Change toggle to add/remove * Revert add/removeNode if node state is inconsistent * Fix remappings * Fix Angstrom to use only memory signatures * Add comments * Use unlockAngstromWithSignature directly * Apply suggestions from code review Co-authored-by: EndymionJkb <EndymionJkb@gmail.com> * Fix register/deregister nodes --------- Co-authored-by: Jeff Bennett <endymionjkb@gmail.com> Co-authored-by: Juan Ignacio Ubeira <juani@balancerlabs.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Alternative to #5 . It keeps the local tests running with compilations in forge, which are faster, but run the CI with hardhat contracts, which is closer to the deployment version of the contract.
Type of change
Checklist:
main, or there's a description of how to merge