Fixes sails.models and sails.adapters references
#14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ORM hook would override any models and adapters that were loaded before it and, prior to this change, other hooks would have to load models and adapters when
orm-hook-loadedis emitted. Any hooks that utilize Marlinspike [1] might not work at all, because it loads controllers, models, etc. onconfigurerather than oninitializeand afterorm-hook-loaded.This change was tested on
1.0.0-42of Sails and it enables models and adapters to be loaded onconfigure.[1] https://github.com/tjwebb/marlinspike