fix destroyed BDA buffers staying tracked#3766
Merged
baldurk merged 1 commit intobaldurk:v1.xfrom Jan 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UntrackBufferAddress makes use of m_DeviceAddressResources to figure out if the buffer has a BDA or not (and if so, removed it from the tracking system) and currently we're removing the buffer from m_DeviceAddressResources.IDs before Untracking it, so untrack cannot go forward.
This deprecates m_DeviceAddressResources.IDs entirely and stores BDA-ness (for both buffers and memory) in the resourcerecord instead, which makes it order-independent. One m_DeviceAddressResources.IDs add is removed entirely as it was replay only, which doesn't have a record and also doesn't make use of hasBDA at all, since address tracking is capture-only.
This fixes indirect diffuse on my test, which was deleting BDA buffers every frame and recreating them.