Jump to the entry point line when viewing or editing a shader#3771
Closed
qwmnerbvqwmn wants to merge 1 commit intobaldurk:v1.xfrom
Closed
Jump to the entry point line when viewing or editing a shader#3771qwmnerbvqwmn wants to merge 1 commit intobaldurk:v1.xfrom
qwmnerbvqwmn wants to merge 1 commit intobaldurk:v1.xfrom
Conversation
ab02918 to
2b8c64c
Compare
2b8c64c to
77e7714
Compare
Owner
|
I do not want to make this change. This is too complicated and error prone and the code that's already there does the most reliable thing it can. This is making the big assumption that the entry point name is unique enough to only show up in one place which may be true for some shaders but definitely isn't true in the general case. The existing code already uses the debug info to scroll to the entry point where available, since that is verifiable and always correct. Doing text-searches for the entry point string and scrolling is not reliable enough for me to be happy doing that as a very common entry point name is going to be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves UX by automatically scrolling the shader editor to the line where the entry point function is defined when a user opens a shader for viewing or editing.